Re: [PATCH] mtd: gpmi: Always report ECC stats and return max_bitflips

[Huang Shijie <b32955@freescale.com>]

于 2012年12月14日 10:39, Zach Sadecki 写道:
> On 12/13/2012 05:27 AM, Artem Bityutskiy wrote:
>> On Mon, 2012-12-10 at 09:18 -0600, Zach Sadecki wrote:
>>> Always report corrected and failed ECC stats back up to the MTD 
>>> layer. Also
>>> return max_bitflips from read_page() as is expected from NAND 
>>> drivers now.
>>>
>>> Signed-off-by: Zach Sadecki <zsadecki@itwatchdogs.com>
>>> Acked-by: Huang Shijie <b32955 at freescale.com>
>>> ---
>> Dunno, may be your patch is corrupted or something. Try to save it and
>> apply. This is what I get:
>>
>> $ git apply --check ~/tmp/zach.mbox
>> error: patch failed: drivers/mtd/nand/gpmi-nand/gpmi-nand.c:921
>> error: drivers/mtd/nand/gpmi-nand/gpmi-nand.c: patch does not apply
>>
>> $ git log -1 --oneline
>> 70df8b3 mtd: nand: gpmi: reset BCH earlier, too, to avoid NAND 
>> startup problems
>>
>> I've attached the zach.mbox file for you.
>>
> OK. I rebased the patch on the latest l2-mtd and I tested it with git 
> apply, so this one should work...
>
> Sent as a separate reply with only the patch in it.
Dear Zach,
I think you'd better check the patch with /scripts/checkpatch.pl before 
you send out the patch.
I saw many "trailing whitespace" in your patch.

thanks.

Huang Shijie