From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <50F60768.5040509@atmel.com> Date: Wed, 16 Jan 2013 09:50:32 +0800 From: Bo Shen MIME-Version: 1.0 To: dedekind1@gmail.com Subject: Re: [PATCH 1/3] MTD: at91: atmel_nand: for PMECC, add code to choose the ecc bits and sector size according to the ONFI parameter ECC requirement. References: <1355912840-29501-1-git-send-email-josh.wu@atmel.com> <1355912840-29501-2-git-send-email-josh.wu@atmel.com> <1358252760.2731.133.camel@sauron.fi.intel.com> In-Reply-To: <1358252760.2731.133.camel@sauron.fi.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Josh Wu , plagnioj@jcrosoft.com, nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Artem Bityutskiy, On 1/15/2013 20:26, Artem Bityutskiy wrote: > I cannot compile this patch: > > ERROR (phandle_references): Reference to non-existent node or label "pinctrl_ssc0_tx" > > ERROR: Input tree has errors, aborting (use -f to force output) > make[2]: *** [arch/arm/boot/dts/at91sam9g20ek.dtb] Error 2 Sorry for this inconvenience. There are patches doesn't go to mainline in time which cause this issue. [1] https://patchwork.kernel.org/patch/1966321/ [2] https://patchwork.kernel.org/patch/1966341/ Best Regards, Bo Shen > > On Wed, 2012-12-19 at 18:27 +0800, Josh Wu wrote: >> This patch will check NAND flash's ecc minimum requirement in ONFI parameter. If it is equal or smaller than pmecc-cap in dtsi, then use ecc_bits in ONFI. otherwise, return an error since pmecc-cap in dtsi don't meet the ecc minimum reqirement. >> >> This patch also check sector size (codeword) requirement in ONFI. If it is equal or bigger than sector_size in dtsi, then use the one of ONFI. otherwise return error. >> >> Currently we don't support to read the ECC parameter in ONFI extended parameter page. So in that case we just use the value specified in dts. >> >> For non-ONFI nand flash, we assume the minimum ecc requirement is 2bits in 512 bytes. >> >> Signed-off-by: Josh Wu > > Please, wrap the lines like kernel developers usually do. > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >