From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U333V-00076k-Oe for linux-mtd@lists.infradead.org; Wed, 06 Feb 2013 11:20:47 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:6f8:1178:4:5054:ff:fe8d:eefb] helo=bjornoya.do.blackshift.org) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1U333S-0002nP-IG for linux-mtd@lists.infradead.org; Wed, 06 Feb 2013 12:20:42 +0100 Received: from [IPv6:2001:6f8:105b:1122:21d:e0ff:fe39:f61b] (hardanger.wlan.blackshift.org [IPv6:2001:6f8:105b:1122:21d:e0ff:fe39:f61b]) (using TLSv1 with cipher ECDHE-ECDSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: frogger) by bjornoya.do.blackshift.org (Postfix) with ESMTPSA id EAD6A5E901 for ; Wed, 6 Feb 2013 12:20:41 +0100 (CET) Message-ID: <51123C80.2050400@pengutronix.de> Date: Wed, 06 Feb 2013 12:20:32 +0100 From: Marc Kleine-Budde MIME-Version: 1.0 To: linux-mtd@lists.infradead.org Subject: ubifs: possible circular locking dependency Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2JGLWBMMNSFSCTPEHUHWO" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JGLWBMMNSFSCTPEHUHWO Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello, I'm on a arm imx28 v3.8-rc6 (+ a handfull of patches to support the custom board) but no modifications on ubifs, selinux or the vfs layer. And not including the xattr patches by Subodh Nijsure. When booting with SELinux and lockdep enabled I see this circular locking dependency: [ 5.390312] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D [ 5.396500] [ INFO: possible circular locking dependency detected ] [ 5.402781] 3.8.0-rc6-00005-g4f7e39d #49 Not tainted [ 5.407750] ------------------------------------------------------- [ 5.414031] systemd/1 is trying to acquire lock: [ 5.418656] (&c->tnc_mutex){+.+...}, at: [] ubifs_tnc_locat= e+0x30/0x198 [ 5.426343] [ 5.426343] but task is already holding lock: [ 5.432218] (&isec->lock){+.+.+.}, at: [] inode_doinit_with= _dentry+0x8c/0x55c [ 5.440375] [ 5.440375] which lock already depends on the new lock. [ 5.440375] [ 5.448593] [ 5.448593] the existing dependency chain (in reverse order) is: [ 5.456093] -> #4 (&isec->lock){+.+.+.}: [ 5.460250] [] lock_acquire+0x64/0x78 [ 5.465437] [] mutex_lock_nested+0x5c/0x2ec [ 5.471125] [] inode_doinit_with_dentry+0x8c/0x55c [ 5.477437] [] security_d_instantiate+0x1c/0x34 [ 5.483500] [] debugfs_mknod.part.15.constprop.18+0x9= 4/0x128 [ 5.490656] [] __create_file+0x1b0/0x25c [ 5.496093] [] debugfs_create_dir+0x1c/0x28 [ 5.501781] [] pinctrl_init+0x1c/0xd0 [ 5.506968] [] do_one_initcall+0x108/0x17c [ 5.512593] [] kernel_init_freeable+0xec/0x1b4 [ 5.518562] [] kernel_init+0x8/0xe4 [ 5.523562] [] ret_from_fork+0x14/0x2c [ 5.528812] -> #3 (&sb->s_type->i_mutex_key#2){+.+.+.}: [ 5.534312] [] lock_acquire+0x64/0x78 [ 5.539468] [] mutex_lock_nested+0x5c/0x2ec [ 5.545187] [] __create_file+0x50/0x25c [ 5.550531] [] debugfs_create_dir+0x1c/0x28 [ 5.556218] [] clk_debug_create_subtree+0x1c/0x108 [ 5.562500] [] clk_debug_init+0x68/0xc0 [ 5.567875] [] do_one_initcall+0x108/0x17c [ 5.573468] [] kernel_init_freeable+0xec/0x1b4 [ 5.579437] [] kernel_init+0x8/0xe4 [ 5.584437] [] ret_from_fork+0x14/0x2c [ 5.589687] -> #2 (prepare_lock){+.+.+.}: [ 5.593937] [] lock_acquire+0x64/0x78 [ 5.599125] [] mutex_lock_nested+0x5c/0x2ec [ 5.604812] [] clk_prepare+0x18/0x38 [ 5.609906] [] __gpmi_enable_clk+0x30/0xb0 [ 5.615531] [] gpmi_begin+0x18/0x530 [ 5.620625] [] gpmi_select_chip+0x3c/0x54 [ 5.626156] [] nand_do_read_ops+0x7c/0x3e4 [ 5.631750] [] nand_read+0x50/0x74 [ 5.636656] [] part_read+0x5c/0xa4 [ 5.641593] [] mtd_read+0x84/0xb8 [ 5.646406] [] ubi_io_read+0xa0/0x2c0 [ 5.651593] [] ubi_eba_read_leb+0x190/0x424 [ 5.657281] [] ubi_leb_read+0xac/0x120 [ 5.662562] [] ubifs_leb_read+0x28/0x8c [ 5.667906] [] ubifs_read_node+0x98/0x2a0 [ 5.673437] [] ubifs_read_sb_node+0x54/0x78 [ 5.679125] [] ubifs_read_superblock+0xc60/0x163c [ 5.685343] [] ubifs_mount+0x800/0x171c [ 5.690687] [] mount_fs+0x44/0x184 [ 5.695593] [] vfs_kern_mount+0x4c/0xc0 [ 5.700968] [] do_mount+0x18c/0x8d0 [ 5.705968] [] sys_mount+0x84/0xb8 [ 5.710875] [] mount_block_root+0x118/0x258 [ 5.716562] [] prepare_namespace+0x8c/0x17c [ 5.722281] [] kernel_init+0x8/0xe4 [ 5.727281] [] ret_from_fork+0x14/0x2c [ 5.732531] -> #1 (&le->mutex){++++..}: [ 5.736625] [] lock_acquire+0x64/0x78 [ 5.741812] [] down_read+0x40/0x54 [ 5.746718] [] ubi_eba_read_leb+0x34/0x424 [ 5.752312] [] ubi_leb_read+0xac/0x120 [ 5.757562] [] ubifs_leb_read+0x28/0x8c [ 5.762937] [] ubifs_read_node+0x98/0x2a0 [ 5.768437] [] ubifs_load_znode+0x88/0x560 [ 5.774062] [] ubifs_lookup_level0+0x190/0x1dc [ 5.780031] [] ubifs_tnc_locate+0x44/0x198 [ 5.785656] [] ubifs_iget+0x6c/0x8a4 [ 5.790718] [] ubifs_mount+0xc18/0x171c [ 5.796093] [] mount_fs+0x44/0x184 [ 5.801000] [] vfs_kern_mount+0x4c/0xc0 [ 5.806343] [] do_mount+0x18c/0x8d0 [ 5.811343] [] sys_mount+0x84/0xb8 [ 5.816250] [] mount_block_root+0x118/0x258 [ 5.821968] [] prepare_namespace+0x8c/0x17c [ 5.827656] [] kernel_init+0x8/0xe4 [ 5.832656] [] ret_from_fork+0x14/0x2c [ 5.837906] -> #0 (&c->tnc_mutex){+.+...}: [ 5.842250] [] __lock_acquire+0x14ec/0x1b08 [ 5.847968] [] lock_acquire+0x64/0x78 [ 5.853125] [] mutex_lock_nested+0x5c/0x2ec [ 5.858812] [] ubifs_tnc_locate+0x30/0x198 [ 5.864437] [] ubifs_tnc_lookup_nm+0x28/0x150 [ 5.870312] [] ubifs_getxattr+0xc0/0x254 [ 5.875750] [] inode_doinit_with_dentry+0x25c/0x55c [ 5.882125] [] sb_finish_set_opts+0xa4/0x21c [ 5.887906] [] selinux_set_mnt_opts+0x2ec/0x4b8 [ 5.893968] [] superblock_doinit+0xb4/0xc0 [ 5.899562] [] iterate_supers+0xb4/0xdc [ 5.904906] [] security_load_policy+0x248/0x3c4 [ 5.910968] [] sel_write_load+0x9c/0x6a0 [ 5.916406] [] vfs_write+0xa0/0x17c [ 5.921406] [] sys_write+0x3c/0x70 [ 5.926343] [] ret_fast_syscall+0x0/0x38 [ 5.931781] [ 5.931781] other info that might help us debug this: [ 5.931781] [ 5.939781] Chain exists of: &c->tnc_mutex --> &sb->s_type->i_mutex_key#2 --> &isec->lock [ 5.948500] Possible unsafe locking scenario: [ 5.948500] [ 5.954437] CPU0 CPU1 [ 5.958968] ---- ---- [ 5.963500] lock(&isec->lock); [ 5.966781] lock(&sb->s_type->i_mutex_k= ey#2); [ 5.973843] lock(&isec->lock); [ 5.979625] lock(&c->tnc_mutex); [ 5.983062] [ 5.983062] *** DEADLOCK *** [ 5.983062] [ 5.989000] 4 locks held by systemd/1: [ 5.992781] #0: (sel_mutex){+.+.+.}, at: [] sel_write_load= +0x20/0x6a0 [ 6.000343] #1: (&type->s_umount_key#26){.+.+..}, at: [] i= terate_supers+0x90/0xdc [ 6.008968] #2: (&sbsec->lock){+.+.+.}, at: [] selinux_set= _mnt_opts+0x64/0x4b8 [ 6.017343] #3: (&isec->lock){+.+.+.}, at: [] inode_doinit= _with_dentry+0x8c/0x55c [ 6.025937] [ 6.025937] stack backtrace: [ 6.030375] [] (unwind_backtrace+0x0/0xf0) from []= (print_circular_bug+0x25c/0x2a8) [ 6.039843] [] (print_circular_bug+0x25c/0x2a8) from [] (__lock_acquire+0x14ec/0x1b08) [ 6.049531] [] (__lock_acquire+0x14ec/0x1b08) from [] (lock_acquire+0x64/0x78) [ 6.058531] [] (lock_acquire+0x64/0x78) from [] (m= utex_lock_nested+0x5c/0x2ec) [ 6.067531] [] (mutex_lock_nested+0x5c/0x2ec) from [] (ubifs_tnc_locate+0x30/0x198) [ 6.076968] [] (ubifs_tnc_locate+0x30/0x198) from [] (ubifs_tnc_lookup_nm+0x28/0x150) [ 6.086593] [] (ubifs_tnc_lookup_nm+0x28/0x150) from [] (ubifs_getxattr+0xc0/0x254) [ 6.096031] [] (ubifs_getxattr+0xc0/0x254) from []= (inode_doinit_with_dentry+0x25c/0x55c) [ 6.105968] [] (inode_doinit_with_dentry+0x25c/0x55c) from [= ] (sb_finish_set_opts+0xa4/0x21c) [ 6.116281] [] (sb_finish_set_opts+0xa4/0x21c) from [] (selinux_set_mnt_opts+0x2ec/0x4b8) [ 6.126218] [] (selinux_set_mnt_opts+0x2ec/0x4b8) from [] (superblock_doinit+0xb4/0xc0) [ 6.136000] [] (superblock_doinit+0xb4/0xc0) from [] (iterate_supers+0xb4/0xdc) [ 6.145093] [] (iterate_supers+0xb4/0xdc) from [] = (security_load_policy+0x248/0x3c4) [ 6.154625] [] (security_load_policy+0x248/0x3c4) from [] (sel_write_load+0x9c/0x6a0) [ 6.164218] [] (sel_write_load+0x9c/0x6a0) from []= (vfs_write+0xa0/0x17c) [ 6.172781] [] (vfs_write+0xa0/0x17c) from [] (sys= _write+0x3c/0x70) [ 6.180843] [] (sys_write+0x3c/0x70) from [] (ret_= fast_syscall+0x0/0x38) Any hints how to solve the problem? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | ------enig2JGLWBMMNSFSCTPEHUHWO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlESPIMACgkQjTAFq1RaXHMJAwCfVKBVG4aUkVUFIEcF4oNZqecx ADYAoIg8orCKDqcgo5744p+j7l1YClY3 =OlUy -----END PGP SIGNATURE----- ------enig2JGLWBMMNSFSCTPEHUHWO--