* [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages [not found] <20130119011231.20902.55954.stgit@blackbox.djwong.org> @ 2013-01-19 1:13 ` Darrick J. Wong 2013-01-23 21:43 ` Andrew Morton 0 siblings, 1 reply; 7+ messages in thread From: Darrick J. Wong @ 2013-01-19 1:13 UTC (permalink / raw) To: axboe, lucho, jack, darrick.wong, ericvh, viro, rminnich, tytso Cc: martin.petersen, Artem Bityutskiy, neilb, linux-kernel, david, gnehzuil.liu, Adrian Hunter, hch, jlayton, adilger.kernel, bharrosh, linux-fsdevel, linux-mtd, akpm, linux-ext4, hirofumi When stable pages are required, we have to wait if the page is just going to disk and we want to modify it. Add proper callback to ubifs_vm_page_mkwrite(). CC: Artem Bityutskiy <dedekind1@gmail.com> CC: Adrian Hunter <adrian.hunter@intel.com> CC: linux-mtd@lists.infradead.org From: Jan Kara <jack@suse.cz> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- fs/ubifs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 5bc7781..4f6493c 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c @@ -1522,6 +1522,7 @@ static int ubifs_vm_page_mkwrite(struct vm_area_struct *vma, ubifs_release_dirty_inode_budget(c, ui); } + wait_for_stable_page(page); unlock_page(page); return 0; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages 2013-01-19 1:13 ` [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages Darrick J. Wong @ 2013-01-23 21:43 ` Andrew Morton 2013-02-21 3:48 ` Darrick J. Wong 0 siblings, 1 reply; 7+ messages in thread From: Andrew Morton @ 2013-01-23 21:43 UTC (permalink / raw) To: Darrick J. Wong Cc: lucho, jack, neilb, david, Adrian Hunter, adilger.kernel, jlayton, hch, gnehzuil.liu, bharrosh, linux-ext4, ericvh, viro, rminnich, hirofumi, axboe, tytso, martin.petersen, Artem Bityutskiy, linux-kernel, linux-fsdevel, linux-mtd On Fri, 18 Jan 2013 17:13:16 -0800 "Darrick J. Wong" <darrick.wong@oracle.com> wrote: > When stable pages are required, we have to wait if the page is just > going to disk and we want to modify it. Add proper callback to > ubifs_vm_page_mkwrite(). > > CC: Artem Bityutskiy <dedekind1@gmail.com> > CC: Adrian Hunter <adrian.hunter@intel.com> > CC: linux-mtd@lists.infradead.org > From: Jan Kara <jack@suse.cz> > Signed-off-by: Jan Kara <jack@suse.cz> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> A couple of these patches had this From:Jan strangely embedded in the signoff area. I have assumed that they were indeed authored by Jan. Please note that authorship is indicated by putting the From: line right at the start of the chagnelog. I grabbed the patches. They should appear in linux-next tomorrow if I can get the current pooppile to build. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages 2013-01-23 21:43 ` Andrew Morton @ 2013-02-21 3:48 ` Darrick J. Wong 2013-02-21 9:36 ` Boaz Harrosh 2013-02-21 22:32 ` Andrew Morton 0 siblings, 2 replies; 7+ messages in thread From: Darrick J. Wong @ 2013-02-21 3:48 UTC (permalink / raw) To: Andrew Morton Cc: lucho, jack, neilb, david, Adrian Hunter, adilger.kernel, jlayton, hch, gnehzuil.liu, bharrosh, linux-ext4, ericvh, viro, rminnich, hirofumi, axboe, tytso, martin.petersen, Artem Bityutskiy, linux-kernel, linux-fsdevel, linux-mtd On Wed, Jan 23, 2013 at 01:43:12PM -0800, Andrew Morton wrote: > On Fri, 18 Jan 2013 17:13:16 -0800 > "Darrick J. Wong" <darrick.wong@oracle.com> wrote: > > > When stable pages are required, we have to wait if the page is just > > going to disk and we want to modify it. Add proper callback to > > ubifs_vm_page_mkwrite(). > > > > CC: Artem Bityutskiy <dedekind1@gmail.com> > > CC: Adrian Hunter <adrian.hunter@intel.com> > > CC: linux-mtd@lists.infradead.org > > From: Jan Kara <jack@suse.cz> > > Signed-off-by: Jan Kara <jack@suse.cz> > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > A couple of these patches had this From:Jan strangely embedded in the > signoff area. I have assumed that they were indeed authored by Jan. > > Please note that authorship is indicated by putting the From: line > right at the start of the chagnelog. > > > I grabbed the patches. They should appear in linux-next tomorrow if I > can get the current pooppile to build. Well... these patches have been banging around in -next for a month or so now. As far as I know there haven't been any complaints. Can we push these for 3.9? --D ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages 2013-02-21 3:48 ` Darrick J. Wong @ 2013-02-21 9:36 ` Boaz Harrosh 2013-02-21 22:32 ` Andrew Morton 1 sibling, 0 replies; 7+ messages in thread From: Boaz Harrosh @ 2013-02-21 9:36 UTC (permalink / raw) To: Darrick J. Wong Cc: lucho, jack, neilb, david, Adrian Hunter, adilger.kernel, jlayton, hch, gnehzuil.liu, linux-ext4, ericvh, viro, rminnich, hirofumi, axboe, tytso, martin.petersen, Artem Bityutskiy, linux-kernel, linux-fsdevel, linux-mtd, Andrew Morton On 02/21/2013 05:48 AM, Darrick J. Wong wrote: > On Wed, Jan 23, 2013 at 01:43:12PM -0800, Andrew Morton wrote: >> On Fri, 18 Jan 2013 17:13:16 -0800 >> "Darrick J. Wong" <darrick.wong@oracle.com> wrote: >> >>> When stable pages are required, we have to wait if the page is just >>> going to disk and we want to modify it. Add proper callback to >>> ubifs_vm_page_mkwrite(). >>> >>> CC: Artem Bityutskiy <dedekind1@gmail.com> >>> CC: Adrian Hunter <adrian.hunter@intel.com> >>> CC: linux-mtd@lists.infradead.org >>> From: Jan Kara <jack@suse.cz> >>> Signed-off-by: Jan Kara <jack@suse.cz> >>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> >> >> A couple of these patches had this From:Jan strangely embedded in the >> signoff area. I have assumed that they were indeed authored by Jan. >> >> Please note that authorship is indicated by putting the From: line >> right at the start of the chagnelog. >> >> >> I grabbed the patches. They should appear in linux-next tomorrow if I >> can get the current pooppile to build. > > Well... these patches have been banging around in -next for a month or so now. > As far as I know there haven't been any complaints. Can we push these for 3.9? > Yes, please I'm waiting for these patches as well. Lets push them this merge window. I was sure they would get in at 3.8, but they didn't. What's the delay? [Using this I can fix a theoretical raid corruption in exofs local access, which no one really cared because exofs is always accessed via pnfs, which does not have that bug] Thanks Boaz > --D > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages 2013-02-21 3:48 ` Darrick J. Wong 2013-02-21 9:36 ` Boaz Harrosh @ 2013-02-21 22:32 ` Andrew Morton 2013-02-21 22:40 ` Darrick J. Wong 1 sibling, 1 reply; 7+ messages in thread From: Andrew Morton @ 2013-02-21 22:32 UTC (permalink / raw) To: Darrick J. Wong Cc: lucho, jack, neilb, david, Adrian Hunter, adilger.kernel, jlayton, hch, gnehzuil.liu, bharrosh, linux-ext4, ericvh, viro, rminnich, hirofumi, axboe, tytso, martin.petersen, Artem Bityutskiy, linux-kernel, linux-fsdevel, linux-mtd On Wed, 20 Feb 2013 19:48:34 -0800 "Darrick J. Wong" <darrick.wong@oracle.com> wrote: > > I grabbed the patches. They should appear in linux-next tomorrow if I > > can get the current pooppile to build. > > Well... these patches have been banging around in -next for a month or so now. > As far as I know there haven't been any complaints. Can we push these for 3.9? yup. You can normally assume that this is the case, unless the patches have a) been causing bugs or b) been getting rude review comments or c) been getting a great string of fix-fix-fix-fix patches in -mm or d) acquired rude akpm comments or unresolved questions against them in http://ozlabs.org/~akpm/mmots/series ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages 2013-02-21 22:32 ` Andrew Morton @ 2013-02-21 22:40 ` Darrick J. Wong 0 siblings, 0 replies; 7+ messages in thread From: Darrick J. Wong @ 2013-02-21 22:40 UTC (permalink / raw) To: Andrew Morton Cc: lucho, jack, neilb, david, Adrian Hunter, adilger.kernel, jlayton, hch, gnehzuil.liu, bharrosh, linux-ext4, ericvh, viro, rminnich, hirofumi, axboe, tytso, martin.petersen, Artem Bityutskiy, linux-kernel, linux-fsdevel, linux-mtd On Thu, Feb 21, 2013 at 02:32:43PM -0800, Andrew Morton wrote: > On Wed, 20 Feb 2013 19:48:34 -0800 > "Darrick J. Wong" <darrick.wong@oracle.com> wrote: > > > > I grabbed the patches. They should appear in linux-next tomorrow if I > > > can get the current pooppile to build. > > > > Well... these patches have been banging around in -next for a month or so now. > > As far as I know there haven't been any complaints. Can we push these for 3.9? > > yup. You can normally assume that this is the case, unless the patches have > > a) been causing bugs or > > b) been getting rude review comments or > > c) been getting a great string of fix-fix-fix-fix patches in -mm or > > d) acquired rude akpm comments or unresolved questions against them > in http://ozlabs.org/~akpm/mmots/series I was simply making sure that I hadn't missed anything. :) --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20130115054235.1563.12967.stgit@blackbox.djwong.org>]
* [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages [not found] <20130115054235.1563.12967.stgit@blackbox.djwong.org> @ 2013-01-15 5:43 ` Darrick J. Wong 0 siblings, 0 replies; 7+ messages in thread From: Darrick J. Wong @ 2013-01-15 5:43 UTC (permalink / raw) To: axboe, lucho, jack, darrick.wong, ericvh, tytso, viro, rminnich Cc: martin.petersen, Artem Bityutskiy, neilb, linux-kernel, david, gnehzuil.liu, Adrian Hunter, hch, jlayton, adilger.kernel, bharrosh, linux-fsdevel, linux-mtd, linux-ext4, hirofumi When stable pages are required, we have to wait if the page is just going to disk and we want to modify it. Add proper callback to ubifs_vm_page_mkwrite(). CC: Artem Bityutskiy <dedekind1@gmail.com> From: Jan Kara <jack@suse.cz> CC: Adrian Hunter <adrian.hunter@intel.com> CC: linux-mtd@lists.infradead.org Signed-off-by: Jan Kara <jack@suse.cz> --- fs/ubifs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 5bc7781..4f6493c 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c @@ -1522,6 +1522,7 @@ static int ubifs_vm_page_mkwrite(struct vm_area_struct *vma, ubifs_release_dirty_inode_budget(c, ui); } + wait_for_stable_page(page); unlock_page(page); return 0; ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-21 22:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130119011231.20902.55954.stgit@blackbox.djwong.org>
2013-01-19 1:13 ` [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages Darrick J. Wong
2013-01-23 21:43 ` Andrew Morton
2013-02-21 3:48 ` Darrick J. Wong
2013-02-21 9:36 ` Boaz Harrosh
2013-02-21 22:32 ` Andrew Morton
2013-02-21 22:40 ` Darrick J. Wong
[not found] <20130115054235.1563.12967.stgit@blackbox.djwong.org>
2013-01-15 5:43 ` Darrick J. Wong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox