public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	linux-mtd@lists.infradead.org,
	David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH] mtd/nand: don't use {read,write}_buf for 8-bit transfers
Date: Thu, 28 Feb 2013 10:47:43 +0800	[thread overview]
Message-ID: <512EC54F.3090400@freescale.com> (raw)
In-Reply-To: <1361977852-18233-1-git-send-email-u.kleine-koenig@pengutronix.de>

于 2013年02月27日 23:10, Uwe Kleine-König 写道:
> According to the Open NAND Flash Interface Specification (ONFI) Revision
> 3.1 "Parameters are always transferred on the lower 8-bits of the data
> bus." for the Get Features and Set Features commands.
>
yes. the set/get features should works in 8-bit.

I have never met a 16-bit onfi nand yet. :)

> So using read_buf and write_buf is wrong for 16-bit wide nand chips as
> they use I/O[15:0]. The Get Features command is easily fixed using 4
> times the read_byte callback. For Set Features error out as there is no
yes. for get features, it's easy to fix it.
> write_byte callback.
Most of the time, the nand controller will overwrite the write_buf hook...
I also think we need a write_byte callback.

thanks
Huang Shijie

  reply	other threads:[~2013-02-28  2:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 15:10 [PATCH] mtd/nand: don't use {read,write}_buf for 8-bit transfers Uwe Kleine-König
2013-02-28  2:47 ` Huang Shijie [this message]
2013-02-28  9:30   ` Uwe Kleine-König
2013-02-28 10:48   ` Uwe Kleine-König
2013-03-01  3:34     ` Huang Shijie
2013-03-01  8:50       ` Uwe Kleine-König
2013-03-01  8:59         ` Huang Shijie
2013-03-01  9:20   ` Matthieu CASTET
2013-03-01  9:59     ` Uwe Kleine-König
2013-03-01 14:00       ` Matthieu CASTET
2013-02-28 10:33 ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512EC54F.3090400@freescale.com \
    --to=b32955@freescale.com \
    --cc=David.Woodhouse@intel.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox