* Diskonchip regression
@ 2013-03-04 9:33 Alexander Shiyan
2013-03-05 7:15 ` Brian Norris
2013-03-05 15:16 ` Artem Bityutskiy
0 siblings, 2 replies; 5+ messages in thread
From: Alexander Shiyan @ 2013-03-04 9:33 UTC (permalink / raw)
To: linux-mtd
Hello All.
I want to inform about diskonchip regression.
Mounting diskonchip partition now failed due "mtd: nand: kill NAND_NO_READRDY" commit.
Bug produce infinite error messages in the console, like this:
# mount /dev/mtdblock5 /mnt/bbox -t jffs2 -o rw
# jffs2: notice: (45) check_node_data: wrong data CRC in data node at 0x00f14f98: read 0xa0fcbcc1, calculated 0xc30e1a36.
jffs2: mtd->read(0x567 bytes from 0xf14a00) returned ECC error
jffs2: notice: (45) check_node_data: wrong data CRC in data node at 0x00f14924: read 0x73ba55cc, calculated 0x12ecdd4b.
jffs2: mtd->read(0x724 bytes from 0xf14200) returned ECC error
...
I found point to bug using "git bisect":
shc@shc /home/git/linux-next $ git bisect log
git bisect start
# bad: [29594404d7fe73cd80eaa4ee8c43dcc53970c60e] Linux 3.7
git bisect bad 29594404d7fe73cd80eaa4ee8c43dcc53970c60e
# good: [a0d271cbfed1dd50278c6b06bead3d00ba0a88f9] Linux 3.6
git bisect good a0d271cbfed1dd50278c6b06bead3d00ba0a88f9
# good: [d66e6737d454553e1e62109d8298ede5351178a4] Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
git bisect good d66e6737d454553e1e62109d8298ede5351178a4
# bad: [e1b28147f684af67bfac989756c27c19859d3d4e] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
git bisect bad e1b28147f684af67bfac989756c27c19859d3d4e
# good: [5e090ed7af10729a396a25df43d69a236e789736] Merge tag 'soc-late' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 5e090ed7af10729a396a25df43d69a236e789736
# good: [0b173bc4daa8f8ec03a85abf5e47b23502ff80af] mm: kill vma flag VM_CAN_NONLINEAR
git bisect good 0b173bc4daa8f8ec03a85abf5e47b23502ff80af
# good: [72055425e53540d9d0e59a57ac8c9b8ce77b62d5] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
git bisect good 72055425e53540d9d0e59a57ac8c9b8ce77b62d5
# bad: [10f39f04b2cb7a06ba5d4ea0f20bd156d0367bee] Merge tag 'for-linus-20121009' of git://git.infradead.org/mtd-2.6
git bisect bad 10f39f04b2cb7a06ba5d4ea0f20bd156d0367bee
# bad: [b05a1187bbf35035300313987cbd22e362d71dc6] mtd: allow uclinux map driver to be used on any ColdFire CPU platform
git bisect bad b05a1187bbf35035300313987cbd22e362d71dc6
# bad: [d5842ab730d368ae2e8925dc00aec0ca132b72ab] mtd: lpc32xx_slc: Make probe() return -EPROBE_DEFER if necessary
git bisect bad d5842ab730d368ae2e8925dc00aec0ca132b72ab
# bad: [71885b650ab0fd9d2d35cd922bf949c07c171b04] mtd: mxc_nand: swap iomem resource order
git bisect bad 71885b650ab0fd9d2d35cd922bf949c07c171b04
# good: [623c55caa37203ece6b4450daa0d2d058255da30] mtd: sh_flctl: Group sector accesses into a single transfer
git bisect good 623c55caa37203ece6b4450daa0d2d058255da30
# good: [63d99c0e89039e1509209d36ee17fc374fd112c9] mtd: nand: remove NAND_BBT_SEARCH option
git bisect good 63d99c0e89039e1509209d36ee17fc374fd112c9
# bad: [9d6367f4f7835131b2b3987d134fd4c44636fa8d] mtd: add JEDEC ID for w25q32dw to chip table
git bisect bad 9d6367f4f7835131b2b3987d134fd4c44636fa8d
# bad: [3d059693f6e0489066a98f455601137fa003df77] nand: mxc_nand: Use clk_prepare_enable/clk_disable_unprepare
git bisect bad 3d059693f6e0489066a98f455601137fa003df77
shc@shc /home/git/linux-next $ git bisect bad
1696e6bc2ae83734e64e206ac99766ea19e9a14e is the first bad commit
commit 1696e6bc2ae83734e64e206ac99766ea19e9a14e
Author: Brian Norris <computersforpeace@gmail.com>
Date: Tue May 22 23:50:00 2012 -0700
mtd: nand: kill NAND_NO_READRDY
According to its documentation, the NAND_NO_READRDY option is always used
when autoincrement is not supported. Autoincrement support was recently
dropped, so we can drop this options as well (defaulting to "no read ready
check").
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
:040000 040000 5bf782761ebf2573393a9900b18f18901855be90 9633fd4d5e881a7d504c3f55656857f0f8d64052 M drivers
:040000 040000 d8bdeae25e074d3cc915321e0612d666bf692e0a d9de9de1e651791832265d9492f7e794d377d948 M include
So, should we revert this commit or find another solution?
Thanks.
---
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Diskonchip regression
2013-03-04 9:33 Diskonchip regression Alexander Shiyan
@ 2013-03-05 7:15 ` Brian Norris
2013-03-05 15:16 ` Artem Bityutskiy
1 sibling, 0 replies; 5+ messages in thread
From: Brian Norris @ 2013-03-05 7:15 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-mtd, Artem Bityutskiy
On 03/04/2013 01:33 AM, Alexander Shiyan wrote:
> Hello All.
Hi Alexander,
> I want to inform about diskonchip regression.
> Mounting diskonchip partition now failed due "mtd: nand: kill NAND_NO_READRDY" commit.
>
> Bug produce infinite error messages in the console, like this:
> # mount /dev/mtdblock5 /mnt/bbox -t jffs2 -o rw
> # jffs2: notice: (45) check_node_data: wrong data CRC in data node at 0x00f14f98: read 0xa0fcbcc1, calculated 0xc30e1a36.
> jffs2: mtd->read(0x567 bytes from 0xf14a00) returned ECC error
> jffs2: notice: (45) check_node_data: wrong data CRC in data node at 0x00f14924: read 0x73ba55cc, calculated 0x12ecdd4b.
> jffs2: mtd->read(0x724 bytes from 0xf14200) returned ECC error
> ...
>
> I found point to bug using "git bisect":
> shc@shc /home/git/linux-next $ git bisect log
> git bisect start
...
> git bisect bad 3d059693f6e0489066a98f455601137fa003df77
> shc@shc /home/git/linux-next $ git bisect bad
> 1696e6bc2ae83734e64e206ac99766ea19e9a14e is the first bad commit
> commit 1696e6bc2ae83734e64e206ac99766ea19e9a14e
> Author: Brian Norris <computersforpeace@gmail.com>
> Date: Tue May 22 23:50:00 2012 -0700
>
> mtd: nand: kill NAND_NO_READRDY
>
> According to its documentation, the NAND_NO_READRDY option is always used
> when autoincrement is not supported. Autoincrement support was recently
> dropped, so we can drop this options as well (defaulting to "no read ready
> check").
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
>
> :040000 040000 5bf782761ebf2573393a9900b18f18901855be90 9633fd4d5e881a7d504c3f55656857f0f8d64052 M drivers
> :040000 040000 d8bdeae25e074d3cc915321e0612d666bf692e0a d9de9de1e651791832265d9492f7e794d377d948 M include
>
> So, should we revert this commit or find another solution?
Including a CC for the author would have been nice :) I found this only
because you commented about DoC on another thread.
Does your DoC use small page size (i.e., 512B)? Can you provide a little
more information regarding the NAND chip used (e.g., any of
manufacturer, part number, page/eraseblock/device size, etc.), so I can
document this a little better?
Anyway, I believe I overlooked some things in that patch. The original
documentation for NAND_NO_READRDY included "True for all large page
devices, as they do not support autoincrement." I was conflating "not
support autoincrement" with the NAND_NO_AUTOINCR option, which was in
fact doing nothing. But of course that didn't mean NAND_NO_READRDY was
doing nothing...
I would recommend a revert (probably sent to stable). I can send this as
an explicit patch myself soon, if given a little more info. Sorry for
the bug!
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Diskonchip regression
2013-03-04 9:33 Diskonchip regression Alexander Shiyan
2013-03-05 7:15 ` Brian Norris
@ 2013-03-05 15:16 ` Artem Bityutskiy
2013-03-06 3:41 ` Mike Dunn
1 sibling, 1 reply; 5+ messages in thread
From: Artem Bityutskiy @ 2013-03-05 15:16 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-mtd
On Mon, 2013-03-04 at 13:33 +0400, Alexander Shiyan wrote:
> Hello All.
>
> I want to inform about diskonchip regression.
> Mounting diskonchip partition now failed due "mtd: nand: kill NAND_NO_READRDY" commit.
Which diskonchip is that? I was thinking about submitting an RFC about
killing all diskonchip stuff except of doc3g and docg4.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Diskonchip regression
2013-03-05 15:16 ` Artem Bityutskiy
@ 2013-03-06 3:41 ` Mike Dunn
2013-03-06 7:06 ` Artem Bityutskiy
0 siblings, 1 reply; 5+ messages in thread
From: Mike Dunn @ 2013-03-06 3:41 UTC (permalink / raw)
To: linux-mtd
On 03/05/2013 07:16 AM, Artem Bityutskiy wrote:
> On Mon, 2013-03-04 at 13:33 +0400, Alexander Shiyan wrote:
>> Hello All.
>>
>> I want to inform about diskonchip regression.
>> Mounting diskonchip partition now failed due "mtd: nand: kill NAND_NO_READRDY" commit.
>
> Which diskonchip is that? I was thinking about submitting an RFC about
> killing all diskonchip stuff except of doc3g and docg4.
>
I was surprised to learn of a user of the legacy diskonchips out there.
Mike
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Diskonchip regression
2013-03-06 3:41 ` Mike Dunn
@ 2013-03-06 7:06 ` Artem Bityutskiy
0 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2013-03-06 7:06 UTC (permalink / raw)
To: Mike Dunn; +Cc: linux-mtd
On Tue, 2013-03-05 at 19:41 -0800, Mike Dunn wrote:
> On 03/05/2013 07:16 AM, Artem Bityutskiy wrote:
> > On Mon, 2013-03-04 at 13:33 +0400, Alexander Shiyan wrote:
> >> Hello All.
> >>
> >> I want to inform about diskonchip regression.
> >> Mounting diskonchip partition now failed due "mtd: nand: kill NAND_NO_READRDY" commit.
> >
> > Which diskonchip is that? I was thinking about submitting an RFC about
> > killing all diskonchip stuff except of doc3g and docg4.
> >
>
> I was surprised to learn of a user of the legacy diskonchips out there.
Yeah. Let's keep this stuff fore few more years then.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-06 7:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04 9:33 Diskonchip regression Alexander Shiyan
2013-03-05 7:15 ` Brian Norris
2013-03-05 15:16 ` Artem Bityutskiy
2013-03-06 3:41 ` Mike Dunn
2013-03-06 7:06 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox