From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from co1ehsobe003.messaging.microsoft.com ([216.32.180.186] helo=co1outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UD6xS-0004yS-9M for linux-mtd@lists.infradead.org; Wed, 06 Mar 2013 05:32:07 +0000 Message-ID: <5136D4EE.2020806@freescale.com> Date: Wed, 6 Mar 2013 13:32:30 +0800 From: Huang Shijie MIME-Version: 1.0 To: Subject: Re: [PATCH 12/12] mtd: nand: provision full ID support References: <1362415349-7107-1-git-send-email-dedekind1@gmail.com> <1362415349-7107-13-git-send-email-dedekind1@gmail.com> <1362479827.2943.49.camel@sauron> In-Reply-To: <1362479827.2943.49.camel@sauron> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Cc: Mike Dunn , Brian Norris , MTD Maling List List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , =E4=BA=8E 2013=E5=B9=B403=E6=9C=8805=E6=97=A5 18:37, Artem Bityutskiy =E5= =86=99=E9=81=93: > I was thinking about > > if (type->mfr_id =3D=3D 0) > /* this is device-only ID */ > else > /* this is full ID */ > > or > > static inline bool is_full_nand_id(type) { > return type->mfr_id; > } okay. If you think we should not add another table for the full-id nand. I will follow your advice. thanks Huang Shijie