From: Josh Wu <josh.wu@atmel.com>
To: Josh Wu <josh.wu@atmel.com>, <akpm@linux-foundation.org>
Cc: dedekind1@gmail.com, egtvedt@samfundet.no,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
fengguang.wu@intel.com, hskinnemoen@gmail.com
Subject: Re: [PATCH v2] avr32: fix build error in atstk1006_defconfig
Date: Mon, 8 Apr 2013 15:06:47 +0800 [thread overview]
Message-ID: <51626C87.6090800@atmel.com> (raw)
In-Reply-To: <1364797597-22005-1-git-send-email-josh.wu@atmel.com>
Hi, Andrew
Could you merge it for avr32? Thanks in advance.
Best Regards,
Josh Wu
On 4/1/2013 2:26 PM, Josh Wu wrote:
> fixed the following compile error when use avr32 atstk1006_defconfig:
> drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_location':
> drivers/mtd/nand/atmel_nand.c:639: error: implicit declaration of function 'writel_relaxed'
>
> which was introduced by commit:
> 1c7b874d33b463f7150b1ab4617f000af9b327fd
> mtd: at91: atmel_nand: add Programmable Multibit ECC controller support
> The PMECC for nand flash code uses writel_relaxed(). But in avr32, there is no
> macro "writel_relaxed" defined.
>
> This patch add writex_relaxed macro definitions.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Acked-by: Havard Skinnemoen <havard@skinnemoen.net>
> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> change since v1:
> refined the commit message and wrap it into 80 characters.
>
> arch/avr32/include/asm/io.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/avr32/include/asm/io.h b/arch/avr32/include/asm/io.h
> index cf60d0a..fc6483f 100644
> --- a/arch/avr32/include/asm/io.h
> +++ b/arch/avr32/include/asm/io.h
> @@ -165,6 +165,10 @@ BUILDIO_IOPORT(l, u32)
> #define readw_be __raw_readw
> #define readl_be __raw_readl
>
> +#define writeb_relaxed writeb
> +#define writew_relaxed writew
> +#define writel_relaxed writel
> +
> #define writeb_be __raw_writeb
> #define writew_be __raw_writew
> #define writel_be __raw_writel
prev parent reply other threads:[~2013-04-08 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 6:26 [PATCH v2] avr32: fix build error in atstk1006_defconfig Josh Wu
2013-04-08 7:06 ` Josh Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51626C87.6090800@atmel.com \
--to=josh.wu@atmel.com \
--cc=akpm@linux-foundation.org \
--cc=dedekind1@gmail.com \
--cc=egtvedt@samfundet.no \
--cc=fengguang.wu@intel.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).