linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] avr32: fix build error in atstk1006_defconfig
@ 2013-04-01  6:26 Josh Wu
  2013-04-08  7:06 ` Josh Wu
  0 siblings, 1 reply; 2+ messages in thread
From: Josh Wu @ 2013-04-01  6:26 UTC (permalink / raw)
  To: egtvedt, akpm
  Cc: dedekind1, linux-kernel, Josh Wu, linux-mtd, fengguang.wu,
	hskinnemoen

fixed the following compile error when use avr32 atstk1006_defconfig:
  drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_location':
  drivers/mtd/nand/atmel_nand.c:639: error: implicit declaration of function 'writel_relaxed'

which was introduced by commit:
  1c7b874d33b463f7150b1ab4617f000af9b327fd
  mtd: at91: atmel_nand: add Programmable Multibit ECC controller support
The PMECC for nand flash code uses writel_relaxed(). But in avr32, there is no
macro "writel_relaxed" defined.

This patch add writex_relaxed macro definitions.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
Acked-by: Havard Skinnemoen <havard@skinnemoen.net>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
---
change since v1:
 refined the commit message and wrap it into 80 characters.

 arch/avr32/include/asm/io.h |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/avr32/include/asm/io.h b/arch/avr32/include/asm/io.h
index cf60d0a..fc6483f 100644
--- a/arch/avr32/include/asm/io.h
+++ b/arch/avr32/include/asm/io.h
@@ -165,6 +165,10 @@ BUILDIO_IOPORT(l, u32)
 #define readw_be			__raw_readw
 #define readl_be			__raw_readl
 
+#define writeb_relaxed			writeb
+#define writew_relaxed			writew
+#define writel_relaxed			writel
+
 #define writeb_be			__raw_writeb
 #define writew_be			__raw_writew
 #define writel_be			__raw_writel
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] avr32: fix build error in atstk1006_defconfig
  2013-04-01  6:26 [PATCH v2] avr32: fix build error in atstk1006_defconfig Josh Wu
@ 2013-04-08  7:06 ` Josh Wu
  0 siblings, 0 replies; 2+ messages in thread
From: Josh Wu @ 2013-04-08  7:06 UTC (permalink / raw)
  To: Josh Wu, akpm
  Cc: dedekind1, egtvedt, linux-kernel, linux-mtd, fengguang.wu,
	hskinnemoen

Hi, Andrew

Could you merge it for avr32? Thanks in advance.

Best Regards,
Josh Wu

On 4/1/2013 2:26 PM, Josh Wu wrote:
> fixed the following compile error when use avr32 atstk1006_defconfig:
>    drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_location':
>    drivers/mtd/nand/atmel_nand.c:639: error: implicit declaration of function 'writel_relaxed'
>
> which was introduced by commit:
>    1c7b874d33b463f7150b1ab4617f000af9b327fd
>    mtd: at91: atmel_nand: add Programmable Multibit ECC controller support
> The PMECC for nand flash code uses writel_relaxed(). But in avr32, there is no
> macro "writel_relaxed" defined.
>
> This patch add writex_relaxed macro definitions.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Acked-by: Havard Skinnemoen <havard@skinnemoen.net>
> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> change since v1:
>   refined the commit message and wrap it into 80 characters.
>
>   arch/avr32/include/asm/io.h |    4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/avr32/include/asm/io.h b/arch/avr32/include/asm/io.h
> index cf60d0a..fc6483f 100644
> --- a/arch/avr32/include/asm/io.h
> +++ b/arch/avr32/include/asm/io.h
> @@ -165,6 +165,10 @@ BUILDIO_IOPORT(l, u32)
>   #define readw_be			__raw_readw
>   #define readl_be			__raw_readl
>   
> +#define writeb_relaxed			writeb
> +#define writew_relaxed			writew
> +#define writel_relaxed			writel
> +
>   #define writeb_be			__raw_writeb
>   #define writew_be			__raw_writew
>   #define writel_be			__raw_writel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-08  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-01  6:26 [PATCH v2] avr32: fix build error in atstk1006_defconfig Josh Wu
2013-04-08  7:06 ` Josh Wu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).