From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Kevin Cernekee <cernekee@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Norbert van Bolhuis <nvbolhuis@aimvalley.nl>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: cfi_cmdset_0002: do_write_buffer timeouts
Date: Mon, 15 Apr 2013 15:55:37 +0800 [thread overview]
Message-ID: <516BB279.9000000@freescale.com> (raw)
In-Reply-To: <CAN8TOE_Em4g9vb=PYYimGvK9_7O5xPAWQwNs_wX9cnskTaXP5Q@mail.gmail.com>
于 2013年04月13日 10:59, Brian Norris 写道:
> Disabling CONFIG_NO_HZ doesn't fix my problem.
I also disable the CONFIG_NO_HZ, and it does not fix my problem too.
But after i remove the mutex_unlock/mutex_lock in
UDELAY/INVALIDATE_CACHE_UDELAY,
my problem disappears. I run for three days, no timeout occurs. (I do
not enable the CONFIG_MTD_XIP).
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1043,17 +1043,13 @@ static void __xipram xip_udelay(struct map_info
*map, struct flchip *chip,
#define UDELAY(map, chip, adr, usec) \
do { \
- mutex_unlock(&chip->mutex); \
cfi_udelay(usec); \
- mutex_lock(&chip->mutex); \
} while (0)
#define INVALIDATE_CACHE_UDELAY(map, chip, adr, len, usec) \
do { \
- mutex_unlock(&chip->mutex); \
INVALIDATE_CACHED_RANGE(map, adr, len); \
cfi_udelay(usec); \
- mutex_lock(&chip->mutex); \
} while (0)
#endif
--
thanks
Huang Shijie
next prev parent reply other threads:[~2013-04-15 7:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN8TOE8dVYxBbb8MtozFio8dS-ypq14U8RuKTo38QcAtXM5Qrw@mail.gmail.com>
2013-04-11 9:00 ` cfi_cmdset_0002: do_write_buffer timeouts Brian Norris
2013-04-11 9:21 ` Huang Shijie
2013-04-11 19:37 ` Brian Norris
2013-04-12 6:23 ` Norbert van Bolhuis
2013-04-13 2:59 ` Brian Norris
2013-04-15 7:55 ` Huang Shijie [this message]
2013-04-17 21:45 ` Brian Norris
2013-04-18 2:09 ` Huang Shijie
2013-04-12 6:34 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516BB279.9000000@freescale.com \
--to=b32955@freescale.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nvbolhuis@aimvalley.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).