From: Huang Shijie <b32955@freescale.com>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dedekind1@gmail.com" <dedekind1@gmail.com>
Subject: Re: [PATCH V4 5/9] mtd: replace the hardcode with the onfi_feature()
Date: Thu, 2 May 2013 14:48:12 +0800 [thread overview]
Message-ID: <51820C2C.1080404@freescale.com> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73E9C0A2F@DBDE04.ent.ti.com>
于 2013年05月02日 14:17, Gupta, Pekon 写道:
> [Pekon]: onfi_feature() is actually not useful unless someone re-scans the
I do not think so. :)
I think the onfi_feature() is useful in the future.
I only add the two feauture for this helper:
[1] 16-bit and
[2] extended parameter page
But in actually, we may add more feature to this helper, such as
_synchronous_.
For example, some driver may support the synchronous mode for the ONFI nand.
We can use this onfi_feature() in the driver to check if the onfi nand
supports this
synchronous feature.
Add this helper makes the code more readable, though we introduce a
little redandancy.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-05-02 6:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 9:08 [PATCH V4 0/9] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-04-26 9:08 ` [PATCH V4 1/9] mtd: add more comment for ecc_strength/ecc_size Huang Shijie
2013-05-15 7:27 ` Artem Bityutskiy
2013-05-15 7:38 ` Huang Shijie
2013-05-15 7:42 ` Artem Bityutskiy
2013-05-15 8:02 ` Huang Shijie
2013-05-15 10:01 ` Artem Bityutskiy
2013-04-26 9:08 ` [PATCH V4 2/9] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-05-02 7:42 ` Gupta, Pekon
2013-04-26 9:08 ` [PATCH V4 3/9] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-04-26 9:08 ` [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-05-02 7:43 ` Gupta, Pekon
2013-05-02 23:39 ` Brian Norris
2013-05-03 2:52 ` Huang Shijie
2013-04-26 9:08 ` [PATCH V4 5/9] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-04-30 10:04 ` Gupta, Pekon
2013-05-02 2:14 ` Huang Shijie
2013-05-02 5:42 ` Gupta, Pekon
2013-05-02 6:01 ` Huang Shijie
2013-05-02 6:17 ` Gupta, Pekon
2013-05-02 6:48 ` Huang Shijie [this message]
2013-05-02 21:24 ` Brian Norris
2013-04-26 9:08 ` [PATCH V4 6/9] mtd: add ECC info for nand_flash_dev{} Huang Shijie
2013-04-26 9:08 ` [PATCH V4 7/9] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-04-26 9:08 ` [PATCH V4 8/9] mtd: add the ecc info for some " Huang Shijie
2013-04-26 9:08 ` [PATCH V4 9/9] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51820C2C.1080404@freescale.com \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox