* [PATCH 11/26] mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:33 Jingoo Han
2013-05-08 10:37 ` Josh Wu
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 6:33 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, Jingoo Han, 'David Woodhouse',
'Josh Wu'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/atmel_nand.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 2d23d29..36c52f5 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1665,7 +1665,6 @@ err_hw_ecc:
err_scan_ident:
err_no_card:
atmel_nand_disable(host);
- platform_set_drvdata(pdev, NULL);
if (host->dma_chan)
dma_release_channel(host->dma_chan);
err_ecc_ioremap:
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 11/26] mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata()
2013-05-07 6:33 [PATCH 11/26] mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-08 10:37 ` Josh Wu
0 siblings, 0 replies; 2+ messages in thread
From: Josh Wu @ 2013-05-08 10:37 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Artem Bityutskiy', 'David Woodhouse', linux-mtd
On 5/7/2013 2:33 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Josh Wu <josh.wu@atmel.com>
Best Regards,
Josh Wu
> ---
> drivers/mtd/nand/atmel_nand.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 2d23d29..36c52f5 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -1665,7 +1665,6 @@ err_hw_ecc:
> err_scan_ident:
> err_no_card:
> atmel_nand_disable(host);
> - platform_set_drvdata(pdev, NULL);
> if (host->dma_chan)
> dma_release_channel(host->dma_chan);
> err_ecc_ioremap:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-08 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 6:33 [PATCH 11/26] mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-08 10:37 ` Josh Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).