From: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
lizefan@huawei.com, dwmw2@infradead.org
Subject: Re: [PATCH] mtd: fix kfree bcm47xxsflash
Date: Wed, 15 May 2013 11:54:42 +0800 [thread overview]
Message-ID: <51930702.7040208@huawei.com> (raw)
In-Reply-To: <1367743225-3484-1-git-send-email-libo.chen@huawei.com>
Hi David,
what do you think of this patch ?
On 2013/5/5 16:40, chenlibo.3@gmail.com wrote:
> From: Libo Chen <libo.chen@huawei.com>
>
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
> index 9526628..4aa9141 100644
> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
> return 0;
>
> err_dev_reg:
> - kfree(&b47s->mtd);
> + kfree(b47s);
> out:
> return err;
> }
>
next prev parent reply other threads:[~2013-05-15 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-05 8:40 [PATCH] mtd: fix kfree bcm47xxsflash chenlibo.3
2013-05-15 3:54 ` Libo Chen [this message]
2013-05-22 3:51 ` [PATCH RESEND] " Libo Chen
2013-05-22 5:32 ` Rafał Miłecki
2013-05-28 12:40 ` Libo Chen
2013-05-28 12:49 ` Rafał Miłecki
2013-05-28 15:29 ` Andy Shevchenko
2013-05-29 2:40 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51930702.7040208@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).