Re: [PATCH V4 5/9] mtd: replace the hardcode with the onfi_feature()

Huang Shijie
2013-05-02T02:13:26Z

于 2013年04月30日 18:04, Gupta, Pekon 写道:
>> - *busw = 0;
>> - if (le16_to_cpu(p->features)& 1)
>> - *busw = NAND_BUSWIDTH_16;
>> +
>> + *busw = (onfi_feature(chip)& ONFI_FEATURE_16_BIT_BUS) ?
>> + NAND_BUSWIDTH_16 : 0;
> Is this really needed ? you have already checked the 'onfi_version' above in
> nand_flash_detect_onfi() ..
> if (!chip->onfi_version) {
> pr_info("%s: unsupported ONFI version: %d\n", __func__, val);
> return 0;
> }
>
>
I think checking the onfi_version has no relationship with this patch. :)
This patch is just replace the hardcode for 16-bit onfi nand check.

thanks
Huang Shijie