Re: [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter Page

Huang Shijie
2013-05-03T02:51:20Z

于 2013年05月03日 07:39, Brian Norris 写道:
> only run the extended parameter page function after that point.
sorry, I prefer to run the extended parameter page function here just
following the case
"p-> ecc_bits != 0xff". IMHO, the two cases should be put together as
the onfi spec tells, rather be split out
far away. The extended parameter page function is just the case
"p->ecc_bits == 0xff".

If we put the nand_flash_detect_ext_param_page() after the point we
reassign the chip->cmdfunc,
It's a little discrete in logic which makes the code not compact enough.

btw: Could you check you email client? I failed several times for the
HTML issue.

thanks
Huang Shijie