Re: [PATCH V4 5/9] mtd: replace the hardcode with the onfi_feature()

Brian Norris
2013-05-02T21:24:41Z

On Wed, May 1, 2013 at 11:48 PM, Huang Shijie <b32955@freescale.com> wrote:
> 于 2013年05月02日 14:17, Gupta, Pekon 写道:
>
>> [Pekon]: onfi_feature() is actually not useful unless someone re-scans the
>
> I do not think so. :)
>
> I think the onfi_feature() is useful in the future.
> I only add the two feauture for this helper:
> [1] 16-bit and
> [2] extended parameter page
>
> But in actually, we may add more feature to this helper, such as
> _synchronous_.
> For example, some driver may support the synchronous mode for the ONFI nand.
> We can use this onfi_feature() in the driver to check if the onfi nand
> supports this
> synchronous feature.
>
> Add this helper makes the code more readable, though we introduce a little
> redandancy.

I agree with the thoughts here. Readability and reusability are
improved a bit by including the ONFI version check.

(BTW, I haven't forgotten this series. I had some distractions here. I
will fully test and provide my Reviewed-by/Tested-by eventually...)

Brian