* [PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous
@ 2013-05-31 14:34 Richard Genoud
2013-06-03 5:44 ` Josh Wu
0 siblings, 1 reply; 2+ messages in thread
From: Richard Genoud @ 2013-05-31 14:34 UTC (permalink / raw)
To: David Woodhouse; +Cc: Richard Genoud, Josh Wu, linux-mtd, linux-kernel
We don't have to issue a warning when a stronger error correting
capability is chosen.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/mtd/nand/atmel_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 2d23d29..2415cdc 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1002,7 +1002,7 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
return err_no;
}
- if (cap != host->pmecc_corr_cap ||
+ if (cap > host->pmecc_corr_cap ||
sector_size != host->pmecc_sector_size)
dev_info(host->dev, "WARNING: Be Caution! Using different PMECC parameters from Nand ONFI ECC reqirement.\n");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous
2013-05-31 14:34 [PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous Richard Genoud
@ 2013-06-03 5:44 ` Josh Wu
0 siblings, 0 replies; 2+ messages in thread
From: Josh Wu @ 2013-06-03 5:44 UTC (permalink / raw)
To: Richard Genoud; +Cc: linux-mtd, David Woodhouse, linux-kernel
On 5/31/2013 10:34 PM, Richard Genoud wrote:
> We don't have to issue a warning when a stronger error correting
> capability is chosen.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Acked-by: Josh Wu <josh.wu@atmel.com>
Best Regards,
Josh Wu
> ---
> drivers/mtd/nand/atmel_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 2d23d29..2415cdc 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -1002,7 +1002,7 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
> return err_no;
> }
>
> - if (cap != host->pmecc_corr_cap ||
> + if (cap > host->pmecc_corr_cap ||
> sector_size != host->pmecc_sector_size)
> dev_info(host->dev, "WARNING: Be Caution! Using different PMECC parameters from Nand ONFI ECC reqirement.\n");
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-03 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31 14:34 [PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous Richard Genoud
2013-06-03 5:44 ` Josh Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).