From: James Hogan <james.hogan@imgtec.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH] mtd: refactor call to request_module
Date: Wed, 10 Jul 2013 09:40:47 +0100 [thread overview]
Message-ID: <51DD1E0F.80101@imgtec.com> (raw)
In-Reply-To: <87hag3cdp0.fsf@rustcorp.com.au>
On 10/07/13 04:10, Rusty Russell wrote:
> Kees Cook <keescook@chromium.org> writes:
>> This reduces the size of the stack frame when calling request_module().
>> Performing the sprintf before the call is not needed.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
I remember reviewing this before, so feel free to add my:
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
next prev parent reply other threads:[~2013-07-10 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:05 [RESEND][PATCH] mtd: refactor call to request_module Kees Cook
2013-07-10 3:10 ` Rusty Russell
2013-07-10 8:40 ` James Hogan [this message]
2013-08-02 15:53 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2013-05-22 23:51 Kees Cook
2013-05-23 4:15 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD1E0F.80101@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox