* [PATCH 05/12] drivers/mtd/nand: don't use devm_pinctrl_get_select_default() in probe [not found] <1373471889-18107-1-git-send-email-wsa@the-dreams.de> @ 2013-07-10 15:57 ` Wolfram Sang 2013-08-02 15:51 ` Artem Bityutskiy 2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang 1 sibling, 1 reply; 7+ messages in thread From: Wolfram Sang @ 2013-07-10 15:57 UTC (permalink / raw) To: linux-kernel Cc: Wolfram Sang, Artem Bityutskiy, Linus Walleij, Josh Wu, linux-mtd, Jean-Christophe PLAGNIOL-VILLARD, David Woodhouse Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/mtd/nand/atmel_nand.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 2d23d29..4653b64a 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -41,7 +41,6 @@ #include <linux/gpio.h> #include <linux/io.h> #include <linux/platform_data/atmel.h> -#include <linux/pinctrl/consumer.h> #include <mach/cpu.h> @@ -1470,7 +1469,6 @@ static int __init atmel_nand_probe(struct platform_device *pdev) struct resource *mem; struct mtd_part_parser_data ppdata = {}; int res; - struct pinctrl *pinctrl; mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!mem) { @@ -1515,13 +1513,6 @@ static int __init atmel_nand_probe(struct platform_device *pdev) nand_chip->IO_ADDR_W = host->io_base; nand_chip->cmd_ctrl = atmel_nand_cmd_ctrl; - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); - if (IS_ERR(pinctrl)) { - dev_err(host->dev, "Failed to request pinctrl\n"); - res = PTR_ERR(pinctrl); - goto err_ecc_ioremap; - } - if (gpio_is_valid(host->board.rdy_pin)) { res = gpio_request(host->board.rdy_pin, "nand_rdy"); if (res < 0) { -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 05/12] drivers/mtd/nand: don't use devm_pinctrl_get_select_default() in probe 2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang @ 2013-08-02 15:51 ` Artem Bityutskiy 0 siblings, 0 replies; 7+ messages in thread From: Artem Bityutskiy @ 2013-08-02 15:51 UTC (permalink / raw) To: Wolfram Sang Cc: David Woodhouse, Linus Walleij, linux-kernel, Josh Wu, linux-mtd, Jean-Christophe PLAGNIOL-VILLARD On Wed, 2013-07-10 at 16:57 +0100, Wolfram Sang wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 06/12] drivers/mtd/nand/gpmi-nand: don't use devm_pinctrl_get_select_default() in probe [not found] <1373471889-18107-1-git-send-email-wsa@the-dreams.de> 2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang @ 2013-07-10 15:57 ` Wolfram Sang 2013-07-11 2:14 ` Huang Shijie ` (2 more replies) 1 sibling, 3 replies; 7+ messages in thread From: Wolfram Sang @ 2013-07-10 15:57 UTC (permalink / raw) To: linux-kernel Cc: Fabio Estevam, Wolfram Sang, Artem Bityutskiy, Huang Shijie, Bill Pemberton, linux-mtd, David Woodhouse Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 25ecfa1..fd49464 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -26,7 +26,6 @@ #include <linux/interrupt.h> #include <linux/module.h> #include <linux/mtd/partitions.h> -#include <linux/pinctrl/consumer.h> #include <linux/of.h> #include <linux/of_device.h> #include <linux/of_mtd.h> @@ -516,7 +515,6 @@ err_clock: static int acquire_resources(struct gpmi_nand_data *this) { - struct pinctrl *pinctrl; int ret; ret = acquire_register_block(this, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME); @@ -535,19 +533,12 @@ static int acquire_resources(struct gpmi_nand_data *this) if (ret) goto exit_dma_channels; - pinctrl = devm_pinctrl_get_select_default(&this->pdev->dev); - if (IS_ERR(pinctrl)) { - ret = PTR_ERR(pinctrl); - goto exit_pin; - } - ret = gpmi_get_clks(this); if (ret) goto exit_clock; return 0; exit_clock: -exit_pin: release_dma_channels(this); exit_dma_channels: release_bch_irq(this); -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 06/12] drivers/mtd/nand/gpmi-nand: don't use devm_pinctrl_get_select_default() in probe 2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang @ 2013-07-11 2:14 ` Huang Shijie 2013-07-11 2:19 ` Huang Shijie 2013-07-20 17:48 ` Linus Walleij 2013-08-02 15:37 ` Artem Bityutskiy 2 siblings, 1 reply; 7+ messages in thread From: Huang Shijie @ 2013-07-11 2:14 UTC (permalink / raw) To: Wolfram Sang Cc: Fabio Estevam, Artem Bityutskiy, linux-kernel, Bill Pemberton, linux-mtd, David Woodhouse 于 2013年07月10日 23:57, Wolfram Sang 写道: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > --- i remember Fabio had already sent a similar patch about this issue. thanks Huang Shijie ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 06/12] drivers/mtd/nand/gpmi-nand: don't use devm_pinctrl_get_select_default() in probe 2013-07-11 2:14 ` Huang Shijie @ 2013-07-11 2:19 ` Huang Shijie 0 siblings, 0 replies; 7+ messages in thread From: Huang Shijie @ 2013-07-11 2:19 UTC (permalink / raw) To: Wolfram Sang Cc: Fabio Estevam, Artem Bityutskiy, linux-kernel, Bill Pemberton, linux-mtd, David Woodhouse 于 2013年07月11日 10:14, Huang Shijie 写道: > 于 2013年07月10日 23:57, Wolfram Sang 写道: >> Since commit ab78029 (drivers/pinctrl: grab default handles from device core), >> we can rely on device core for setting the default pins. Compile tested only. >> >> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) >> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> >> --- > i remember Fabio had already sent a similar patch about this issue. > sorry. Fabio just fix it in the gpmi driver, maybe he did not fix the atmel-nand. thanks Huang Shijie ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 06/12] drivers/mtd/nand/gpmi-nand: don't use devm_pinctrl_get_select_default() in probe 2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang 2013-07-11 2:14 ` Huang Shijie @ 2013-07-20 17:48 ` Linus Walleij 2013-08-02 15:37 ` Artem Bityutskiy 2 siblings, 0 replies; 7+ messages in thread From: Linus Walleij @ 2013-07-20 17:48 UTC (permalink / raw) To: Wolfram Sang, Artem Bityutskiy Cc: Fabio Estevam, linux-kernel@vger.kernel.org, Huang Shijie, Bill Pemberton, linux-mtd@lists.infradead.org, David Woodhouse On Wed, Jul 10, 2013 at 5:57 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Artem if you're OK with this please carry it in the MTD tree. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 06/12] drivers/mtd/nand/gpmi-nand: don't use devm_pinctrl_get_select_default() in probe 2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang 2013-07-11 2:14 ` Huang Shijie 2013-07-20 17:48 ` Linus Walleij @ 2013-08-02 15:37 ` Artem Bityutskiy 2 siblings, 0 replies; 7+ messages in thread From: Artem Bityutskiy @ 2013-08-02 15:37 UTC (permalink / raw) To: Wolfram Sang Cc: Fabio Estevam, linux-kernel, Huang Shijie, Bill Pemberton, linux-mtd, David Woodhouse On Wed, 2013-07-10 at 16:57 +0100, Wolfram Sang wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-02 15:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1373471889-18107-1-git-send-email-wsa@the-dreams.de>
2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2013-08-02 15:51 ` Artem Bityutskiy
2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang
2013-07-11 2:14 ` Huang Shijie
2013-07-11 2:19 ` Huang Shijie
2013-07-20 17:48 ` Linus Walleij
2013-08-02 15:37 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox