Re: [PATCH 05/25] mtd: nand: gpmi-nand: use more sensible error codes at various places

[Huang Shijie <b32955@freescale.com>]

于 2013年07月31日 22:11, Lothar Waßmann 写道:
> Signed-off-by: Lothar Waßmann<LW@KARO-electronics.de>
> ---
>   drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 4f7ec59..9a47189 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -355,7 +355,7 @@ static int acquire_register_block(struct gpmi_nand_data *this,
>   	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res_name);
>   	if (!r) {
>   		pr_err("Can't get resource for %s\n", res_name);
> -		return -ENXIO;
> +		return -ENODEV;
>   	}
>
>   	p = ioremap(r->start, resource_size(r));
> @@ -396,7 +396,7 @@ static int acquire_bch_irq(struct gpmi_nand_data *this, irq_handler_t irq_h)
>   	r = platform_get_resource_byname(pdev, IORESOURCE_IRQ, res_name);
>   	if (!r) {
>   		pr_err("Can't get resource for %s\n", res_name);
> -		return -ENXIO;
> +		return -ENODEV;
>   	}
>
>   	err = request_irq(r->start, irq_h, 0, res_name, this);
> @@ -1597,7 +1597,7 @@ static int gpmi_nand_probe(struct platform_device *pdev)
>   		pdev->id_entry = of_id->data;
>   	} else {
>   		pr_err("Failed to find the right device id.\n");
> -		return -ENOMEM;
> +		return -ENODEV;
>   	}
>
>   	this = kzalloc(sizeof(*this), GFP_KERNEL);
Acked-by: Huang Shijie <b32955@freescale.com>