public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	linux-mtd@lists.infradead.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer)
Date: Thu, 1 Aug 2013 10:15:30 +0800	[thread overview]
Message-ID: <51F9C4C2.8040403@freescale.com> (raw)
In-Reply-To: <1375279887-17928-2-git-send-email-LW@KARO-electronics.de>

于 2013年07月31日 22:11, Lothar Waßmann 写道:
> Signed-off-by: Lothar Waßmann<LW@KARO-electronics.de>
> ---
>   drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index f557a1d..4f7ec59 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1569,19 +1569,19 @@ static const struct platform_device_id gpmi_ids[] = {
>   	{ .name = "imx23-gpmi-nand", .driver_data = IS_MX23, },
>   	{ .name = "imx28-gpmi-nand", .driver_data = IS_MX28, },
>   	{ .name = "imx6q-gpmi-nand", .driver_data = IS_MX6Q, },
> -	{},
> +	{}
>   };
>
>   static const struct of_device_id gpmi_nand_id_table[] = {
>   	{
>   		.compatible = "fsl,imx23-gpmi-nand",
> -		.data = (void *)&gpmi_ids[IS_MX23]
> +		.data = (void *)&gpmi_ids[IS_MX23],
>   	}, {
>   		.compatible = "fsl,imx28-gpmi-nand",
> -		.data = (void *)&gpmi_ids[IS_MX28]
> +		.data = (void *)&gpmi_ids[IS_MX28],
>   	}, {
>   		.compatible = "fsl,imx6q-gpmi-nand",
> -		.data = (void *)&gpmi_ids[IS_MX6Q]
> +		.data = (void *)&gpmi_ids[IS_MX6Q],
>   	}, {}
>   };
>   MODULE_DEVICE_TABLE(of, gpmi_nand_id_table);
is it any bad influence if we do not apply this patch?

I am not clear what we can benefit from this patch.

thanks
Huang Shijie

  parent reply	other threads:[~2013-08-01  2:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1375279887-17928-1-git-send-email-LW@KARO-electronics.de>
2013-08-01  2:12 ` [PATCH 03/25] mtd: nand: gpmi-nand: let the driver core handle pinctrl Huang Shijie
     [not found] ` <1375279887-17928-3-git-send-email-LW@KARO-electronics.de>
2013-08-01  2:13   ` [PATCH 05/25] mtd: nand: gpmi-nand: use more sensible error codes at various places Huang Shijie
     [not found] ` <1375279887-17928-2-git-send-email-LW@KARO-electronics.de>
2013-08-01  2:15   ` Huang Shijie [this message]
2013-08-01  5:50     ` [PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) Lothar Waßmann
2013-08-01  6:14       ` Huang Shijie
2013-08-06 15:13       ` Artem Bityutskiy
2013-08-07  6:09         ` [PATCH 03/25] mtd: nand: gpmi-nand: let the driver core handle pinctrl Lothar Waßmann
2013-08-07  6:09         ` [PATCH/RESEND 1/2] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) Lothar Waßmann
2013-08-07  6:15         ` [PATCH/RESEND v2 0/2] mtd: nand: gpmi-nand: cleanup patches Lothar Waßmann
2013-08-07  6:31           ` Artem Bityutskiy
2013-08-07  6:15         ` [PATCH/RESEND 1/2] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) Lothar Waßmann
2013-08-07  6:15         ` [PATCH/RESEND 2/2] mtd: nand: gpmi-nand: use more sensible error codes at various places Lothar Waßmann
2013-08-30 16:13       ` [PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) David Woodhouse
2013-08-31 13:42         ` Huang Shijie
2013-09-02  6:14         ` Lothar Waßmann
2013-09-02 15:44           ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F9C4C2.8040403@freescale.com \
    --to=b32955@freescale.com \
    --cc=LW@KARO-electronics.de \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox