From: Huang Shijie <b32955@freescale.com>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"dedekind1@gmail.com" <dedekind1@gmail.com>
Subject: Re: [PATCH v3 3/6] mtd: set the ecc step size for master/slave mtd_info
Date: Mon, 12 Aug 2013 17:44:57 +0800 [thread overview]
Message-ID: <5208AE99.6020508@freescale.com> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73E9F2B57@DBDE04.ent.ti.com>
于 2013年08月12日 17:24, Gupta, Pekon 写道:
> [Pekon]: Following Artem's recommendations.. Can this be named as
> chip->ecc.size = ecc_step_size.
> then chip->ecc.bytes = ecc_syndrome_size (or ecc_code_size)
yes, we can rename these fields in the future with another patch set.
> In addition, chip->ecc.bytes should also be helpful for userspace
> utility to determine how much bytes to reserve in spare-area for ECC.
> So exposing that as sysfs entry is also good.
>
I do not need the chip->ecc.bytes. :)
For me, export the chip->ecc.size is enough.
So you can submit a patch if you need this field.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-08-12 9:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 5:24 [PATCH v3 0/6] Export the ECC step size to user applications Huang Shijie
2013-08-12 5:24 ` [PATCH v3 1/6] mtd: add a new field to mtd_info{} Huang Shijie
2013-08-12 5:24 ` [PATCH v3 2/6] mtd: add a new sys node to show the ecc step size Huang Shijie
2013-08-12 5:24 ` [PATCH v3 3/6] mtd: set the ecc step size for master/slave mtd_info Huang Shijie
2013-08-12 7:00 ` Gupta, Pekon
2013-08-12 8:28 ` Huang Shijie
2013-08-12 9:24 ` Gupta, Pekon
2013-08-12 9:44 ` Huang Shijie [this message]
2013-08-13 0:25 ` Brian Norris
2013-08-13 4:29 ` Gupta, Pekon
2013-08-13 6:14 ` Huang Shijie
2013-08-17 18:58 ` Brian Norris
2013-08-12 5:24 ` [PATCH v3 4/6] mtd: set ONFI nand's default hooks in nand_set_defaults() Huang Shijie
2013-08-12 5:24 ` [PATCH v3 5/6] mtd: gpmi: remove the nand_scan() Huang Shijie
2013-08-12 5:24 ` [PATCH v3 6/6] mtd: update the ABI document about the ecc step Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5208AE99.6020508@freescale.com \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox