* m68k: io{read,write} accessors
@ 2013-08-28 18:36 Brian Norris
2013-08-29 8:15 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Brian Norris @ 2013-08-28 18:36 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-m68k, linux-mtd@lists.infradead.org, Alexander Shiyan
It appears that m68k doesn't properly define the io{read,write}
functions. I get complaints like this from my compile testing:
drivers/mtd/nand/nand_base.c: In function 'nand_write_buf':
drivers/mtd/nand/nand_base.c:216:2: error: implicit declaration of
function 'iowrite8_rep' [-Werror=implicit-function-declaration]
drivers/mtd/nand/nand_base.c: In function 'nand_read_buf':
drivers/mtd/nand/nand_base.c:231:2: error: implicit declaration of
function 'ioread8_rep' [-Werror=implicit-function-declaration]
drivers/mtd/nand/nand_base.c: In function 'nand_write_buf16':
drivers/mtd/nand/nand_base.c:247:2: error: implicit declaration of
function 'iowrite16_rep' [-Werror=implicit-function-declaration]
drivers/mtd/nand/nand_base.c: In function 'nand_read_buf16':
drivers/mtd/nand/nand_base.c:263:2: error: implicit declaration of
function 'ioread16_rep' [-Werror=implicit-function-declaration]
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: m68k: io{read,write} accessors
2013-08-28 18:36 m68k: io{read,write} accessors Brian Norris
@ 2013-08-29 8:15 ` Geert Uytterhoeven
2013-08-29 9:09 ` Brian Norris
2013-08-29 11:57 ` Greg Ungerer
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2013-08-29 8:15 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-m68k, linux-mtd@lists.infradead.org, Alexander Shiyan
On Wed, Aug 28, 2013 at 8:36 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> It appears that m68k doesn't properly define the io{read,write}
> functions. I get complaints like this from my compile testing:
>
> drivers/mtd/nand/nand_base.c: In function 'nand_write_buf':
> drivers/mtd/nand/nand_base.c:216:2: error: implicit declaration of
> function 'iowrite8_rep' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/nand_base.c: In function 'nand_read_buf':
> drivers/mtd/nand/nand_base.c:231:2: error: implicit declaration of
> function 'ioread8_rep' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/nand_base.c: In function 'nand_write_buf16':
> drivers/mtd/nand/nand_base.c:247:2: error: implicit declaration of
> function 'iowrite16_rep' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/nand_base.c: In function 'nand_read_buf16':
> drivers/mtd/nand/nand_base.c:263:2: error: implicit declaration of
> function 'ioread16_rep' [-Werror=implicit-function-declaration]
This is a nommu config?
If CONFIG_MMU=y, GENERIC_IOMAP=y and iowrite8_rep() is available.
Greg: is there any reason we can't use GENERIC_IOMAP=y for the nommu
case too?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: m68k: io{read,write} accessors
2013-08-29 8:15 ` Geert Uytterhoeven
@ 2013-08-29 9:09 ` Brian Norris
2013-08-29 11:57 ` Greg Ungerer
1 sibling, 0 replies; 5+ messages in thread
From: Brian Norris @ 2013-08-29 9:09 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-m68k, linux-mtd@lists.infradead.org, Alexander Shiyan
On 08/29/2013 01:15 AM, Geert Uytterhoeven wrote:
> On Wed, Aug 28, 2013 at 8:36 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
>> It appears that m68k doesn't properly define the io{read,write}
>> functions. I get complaints like this from my compile testing:
>>
>> drivers/mtd/nand/nand_base.c: In function 'nand_write_buf':
>> drivers/mtd/nand/nand_base.c:216:2: error: implicit declaration of
>> function 'iowrite8_rep' [-Werror=implicit-function-declaration]
>> drivers/mtd/nand/nand_base.c: In function 'nand_read_buf':
>> drivers/mtd/nand/nand_base.c:231:2: error: implicit declaration of
>> function 'ioread8_rep' [-Werror=implicit-function-declaration]
>> drivers/mtd/nand/nand_base.c: In function 'nand_write_buf16':
>> drivers/mtd/nand/nand_base.c:247:2: error: implicit declaration of
>> function 'iowrite16_rep' [-Werror=implicit-function-declaration]
>> drivers/mtd/nand/nand_base.c: In function 'nand_read_buf16':
>> drivers/mtd/nand/nand_base.c:263:2: error: implicit declaration of
>> function 'ioread16_rep' [-Werror=implicit-function-declaration]
>
> This is a nommu config?
> If CONFIG_MMU=y, GENERIC_IOMAP=y and iowrite8_rep() is available.
Right, CONFIG_MMU=n.
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: m68k: io{read,write} accessors
2013-08-29 8:15 ` Geert Uytterhoeven
2013-08-29 9:09 ` Brian Norris
@ 2013-08-29 11:57 ` Greg Ungerer
2013-08-29 12:07 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Greg Ungerer @ 2013-08-29 11:57 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-m68k, Brian Norris, linux-mtd, Alexander Shiyan
Hi Geert,
----- "Geert Uytterhoeven" <geert@linux-m68k.org> wrote:
> On Wed, Aug 28, 2013 at 8:36 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > It appears that m68k doesn't properly define the io{read,write}
> > functions. I get complaints like this from my compile testing:
> >
> > drivers/mtd/nand/nand_base.c: In function 'nand_write_buf':
> > drivers/mtd/nand/nand_base.c:216:2: error: implicit declaration of
> > function 'iowrite8_rep' [-Werror=implicit-function-declaration]
> > drivers/mtd/nand/nand_base.c: In function 'nand_read_buf':
> > drivers/mtd/nand/nand_base.c:231:2: error: implicit declaration of
> > function 'ioread8_rep' [-Werror=implicit-function-declaration]
> > drivers/mtd/nand/nand_base.c: In function 'nand_write_buf16':
> > drivers/mtd/nand/nand_base.c:247:2: error: implicit declaration of
> > function 'iowrite16_rep' [-Werror=implicit-function-declaration]
> > drivers/mtd/nand/nand_base.c: In function 'nand_read_buf16':
> > drivers/mtd/nand/nand_base.c:263:2: error: implicit declaration of
> > function 'ioread16_rep' [-Werror=implicit-function-declaration]
>
> This is a nommu config?
> If CONFIG_MMU=y, GENERIC_IOMAP=y and iowrite8_rep() is available.
>
> Greg: is there any reason we can't use GENERIC_IOMAP=y for the nommu
> case too?
None at all. Thus this patch:
http://www.spinics.net/lists/linux-m68k/msg06224.html
I have it in the m68knommu git tree, for-next branch. I intend pushing
it for 3.12.
Regards
Greg
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: m68k: io{read,write} accessors
2013-08-29 11:57 ` Greg Ungerer
@ 2013-08-29 12:07 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2013-08-29 12:07 UTC (permalink / raw)
To: Greg Ungerer; +Cc: linux-m68k, Brian Norris, MTD Maling List, Alexander Shiyan
On Thu, Aug 29, 2013 at 1:57 PM, Greg Ungerer
<gregungerer@westnet.com.au> wrote:
> ----- "Geert Uytterhoeven" <geert@linux-m68k.org> wrote:
>> On Wed, Aug 28, 2013 at 8:36 PM, Brian Norris
>> <computersforpeace@gmail.com> wrote:
>> > It appears that m68k doesn't properly define the io{read,write}
>> > functions. I get complaints like this from my compile testing:
>> >
>> > drivers/mtd/nand/nand_base.c: In function 'nand_write_buf':
>> > drivers/mtd/nand/nand_base.c:216:2: error: implicit declaration of
>> > function 'iowrite8_rep' [-Werror=implicit-function-declaration]
>> > drivers/mtd/nand/nand_base.c: In function 'nand_read_buf':
>> > drivers/mtd/nand/nand_base.c:231:2: error: implicit declaration of
>> > function 'ioread8_rep' [-Werror=implicit-function-declaration]
>> > drivers/mtd/nand/nand_base.c: In function 'nand_write_buf16':
>> > drivers/mtd/nand/nand_base.c:247:2: error: implicit declaration of
>> > function 'iowrite16_rep' [-Werror=implicit-function-declaration]
>> > drivers/mtd/nand/nand_base.c: In function 'nand_read_buf16':
>> > drivers/mtd/nand/nand_base.c:263:2: error: implicit declaration of
>> > function 'ioread16_rep' [-Werror=implicit-function-declaration]
>>
>> This is a nommu config?
>> If CONFIG_MMU=y, GENERIC_IOMAP=y and iowrite8_rep() is available.
>>
>> Greg: is there any reason we can't use GENERIC_IOMAP=y for the nommu
>> case too?
>
> None at all. Thus this patch:
>
> http://www.spinics.net/lists/linux-m68k/msg06224.html
Sorry, I had forgotten about this.
> I have it in the m68knommu git tree, for-next branch. I intend pushing
> it for 3.12.
OK, thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-29 12:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-28 18:36 m68k: io{read,write} accessors Brian Norris
2013-08-29 8:15 ` Geert Uytterhoeven
2013-08-29 9:09 ` Brian Norris
2013-08-29 11:57 ` Greg Ungerer
2013-08-29 12:07 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox