public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: joern@lazybastard.org, dwmw2@infradead.org, dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org
Subject: [PATCH] drivers: mtd: remove '__init' from phram_param_call() and ubi_mtd_param_parse()
Date: Mon, 02 Sep 2013 17:51:57 +0800	[thread overview]
Message-ID: <52245FBD.30202@asianux.com> (raw)

phram_param_call() and ubi_mtd_param_parse() are used by
module_param_call(), usually, it need normal funcitons (no '__init'),
so recommend to remove '__init' from them.

The related warnings:

  WARNING: drivers/mtd/devices/phram.o(.data+0xc): Section mismatch in reference from the variable ___param_ops_phram to the variable .init.text:_phram_param_call
  The variable ___param_ops_phram references
  the variable __init _phram_param_call
  If the reference is valid then annotate the
  variable with __init* or __refdata (see linux/init.h) or name the variable:
  *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
  
  WARNING: drivers/mtd/ubi/ubi.o(.data+0x1a4): Section mismatch in reference from the variable ___param_ops_mtd to the variable .init.text:_ubi_mtd_param_parse
  The variable ___param_ops_mtd references
  the variable __init _ubi_mtd_param_parse
  If the reference is valid then annotate the
  variable with __init* or __refdata (see linux/init.h) or name the variable:
  *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 drivers/mtd/devices/phram.c |    2 +-
 drivers/mtd/ubi/build.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index 67823de..bd7496a 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -264,7 +264,7 @@ static int __init phram_setup(const char *val)
 	return ret;
 }
 
-static int __init phram_param_call(const char *val, struct kernel_param *kp)
+static int phram_param_call(const char *val, struct kernel_param *kp)
 {
 	/*
 	 * This function is always called before 'init_phram()', whether
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 315dcc6..c8b9493 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -1382,7 +1382,7 @@ static int __init bytes_str_to_int(const char *str)
  * This function returns zero in case of success and a negative error code in
  * case of error.
  */
-static int __init ubi_mtd_param_parse(const char *val, struct kernel_param *kp)
+static int ubi_mtd_param_parse(const char *val, struct kernel_param *kp)
 {
 	int i, len;
 	struct mtd_dev_param *p;
-- 
1.7.7.6

             reply	other threads:[~2013-09-02  9:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02  9:51 Chen Gang [this message]
2013-09-02 10:30 ` [PATCH] drivers: mtd: remove '__init' from phram_param_call() and ubi_mtd_param_parse() Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52245FBD.30202@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=joern@lazybastard.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox