public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Richard Weinberger <richard@nod.at>
Cc: richard.genoud@gmail.com, linux-mtd@lists.infradead.org,
	dwmw2@infradead.org, linux-kernel@vger.kernel.org,
	dedekind1@gmail.com
Subject: Re: [PATCH] UBI: fix refill_wl_user_pool()
Date: Wed, 04 Sep 2013 10:20:57 +0200	[thread overview]
Message-ID: <5226ED69.8080506@nod.at> (raw)
In-Reply-To: <1377511730-14834-1-git-send-email-richard@nod.at>

Am 26.08.2013 12:08, schrieb Richard Weinberger:
> If no free PEBs are available refill_wl_user_pool() must not
> return with -ENOSPC immediately.
> It has to block till produce_free_peb() produced a free PEB.
> 
> Reported-and-Tested-by: Richard Genoud <richard.genoud@gmail.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  drivers/mtd/ubi/wl.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index c95bfb1..02317c1 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -599,10 +599,6 @@ static void refill_wl_user_pool(struct ubi_device *ubi)
>  	return_unused_pool_pebs(ubi, pool);
>  
>  	for (pool->size = 0; pool->size < pool->max_size; pool->size++) {
> -		if (!ubi->free.rb_node ||
> -		   (ubi->free_count - ubi->beb_rsvd_pebs < 1))
> -			break;
> -
>  		pool->pebs[pool->size] = __wl_get_peb(ubi);
>  		if (pool->pebs[pool->size] < 0)
>  			break;
> 

Artem, please don't forget do apply this patch.

Thanks,
//richard

  reply	other threads:[~2013-09-04  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 10:08 [PATCH] UBI: fix refill_wl_user_pool() Richard Weinberger
2013-09-04  8:20 ` Richard Weinberger [this message]
2013-09-04 15:50   ` David Mosberger-Tang
2013-09-04 16:01     ` Richard Weinberger
2013-09-04 16:03       ` David Mosberger-Tang
2013-09-05  6:09         ` Richard Weinberger
2013-09-05 17:16           ` David Mosberger-Tang
2013-09-20 16:09   ` richard -rw- weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5226ED69.8080506@nod.at \
    --to=richard@nod.at \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.genoud@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox