* [PATCH] mtd: nand: correct extemded param page error handling
@ 2013-09-20 19:44 Brian Norris
2013-09-22 3:00 ` Huang Shijie
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2013-09-20 19:44 UTC (permalink / raw)
To: linux-mtd; +Cc: Huang Shijie, Brian Norris, David Woodhouse
If the ONFI extended parameter page gives codeword_size == 0, the
extended ECC information is corrupt and should not be used. Currently,
we (correctly) avoid using the information, but we don't report the
error to the caller, so the caller doesn't know that we didn't
initialize ecc_strength_ds and ecc_step_ds. Now the caller can warn the
user that it does not have sufficient information.
This also removes the false and useless "ONFI extended param page
detected" debug message (it was printed even on the aforementioned
corruption, and for the success case, we don't really want a print).
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>
---
drivers/mtd/nand/nand_base.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 00022b4..0b39d0c 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2912,12 +2912,13 @@ static int nand_flash_detect_ext_param_page(struct mtd_info *mtd,
/* get the info we want. */
ecc = (struct onfi_ext_ecc_info *)cursor;
- if (ecc->codeword_size) {
- chip->ecc_strength_ds = ecc->ecc_bits;
- chip->ecc_step_ds = 1 << ecc->codeword_size;
+ if (!ecc->codeword_size) {
+ pr_debug("Invalid codeword size\n");
+ goto ext_out;
}
- pr_info("ONFI extended param page detected.\n");
+ chip->ecc_strength_ds = ecc->ecc_bits;
+ chip->ecc_step_ds = 1 << ecc->codeword_size;
ret = 0;
ext_out:
--
1.8.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: correct extemded param page error handling
2013-09-20 19:44 [PATCH] mtd: nand: correct extemded param page error handling Brian Norris
@ 2013-09-22 3:00 ` Huang Shijie
2013-09-25 19:33 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Huang Shijie @ 2013-09-22 3:00 UTC (permalink / raw)
To: Brian Norris; +Cc: David Woodhouse, linux-mtd
于 2013年09月21日 03:44, Brian Norris 写道:
> If the ONFI extended parameter page gives codeword_size == 0, the
> extended ECC information is corrupt and should not be used. Currently,
> we (correctly) avoid using the information, but we don't report the
> error to the caller, so the caller doesn't know that we didn't
> initialize ecc_strength_ds and ecc_step_ds. Now the caller can warn the
> user that it does not have sufficient information.
>
> This also removes the false and useless "ONFI extended param page
> detected" debug message (it was printed even on the aforementioned
> corruption, and for the success case, we don't really want a print).
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Huang Shijie <b32955@freescale.com>
> ---
> drivers/mtd/nand/nand_base.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 00022b4..0b39d0c 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2912,12 +2912,13 @@ static int nand_flash_detect_ext_param_page(struct mtd_info *mtd,
> /* get the info we want. */
> ecc = (struct onfi_ext_ecc_info *)cursor;
>
> - if (ecc->codeword_size) {
> - chip->ecc_strength_ds = ecc->ecc_bits;
> - chip->ecc_step_ds = 1 << ecc->codeword_size;
> + if (!ecc->codeword_size) {
> + pr_debug("Invalid codeword size\n");
> + goto ext_out;
> }
>
> - pr_info("ONFI extended param page detected.\n");
> + chip->ecc_strength_ds = ecc->ecc_bits;
> + chip->ecc_step_ds = 1 << ecc->codeword_size;
> ret = 0;
>
> ext_out:
Acked-by: Huang Shijie <b32955@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: correct extemded param page error handling
2013-09-22 3:00 ` Huang Shijie
@ 2013-09-25 19:33 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2013-09-25 19:33 UTC (permalink / raw)
To: Huang Shijie; +Cc: David Woodhouse, linux-mtd
On Sun, Sep 22, 2013 at 11:00:39AM +0800, Huang Shijie wrote:
> 于 2013年09月21日 03:44, Brian Norris 写道:
> > If the ONFI extended parameter page gives codeword_size == 0, the
> > extended ECC information is corrupt and should not be used. Currently,
> > we (correctly) avoid using the information, but we don't report the
> > error to the caller, so the caller doesn't know that we didn't
> > initialize ecc_strength_ds and ecc_step_ds. Now the caller can warn the
> > user that it does not have sufficient information.
> >
> > This also removes the false and useless "ONFI extended param page
> > detected" debug message (it was printed even on the aforementioned
> > corruption, and for the success case, we don't really want a print).
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Cc: Huang Shijie <b32955@freescale.com>
...
> Acked-by: Huang Shijie <b32955@freescale.com>
Pushed to l2-mtd.git.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-25 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 19:44 [PATCH] mtd: nand: correct extemded param page error handling Brian Norris
2013-09-22 3:00 ` Huang Shijie
2013-09-25 19:33 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox