From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from co9ehsobe004.messaging.microsoft.com ([207.46.163.27]
 helo=co9outboundpool.messaging.microsoft.com)
 by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux))
 id 1VOhxK-0004K4-3N
 for linux-mtd@lists.infradead.org; Wed, 25 Sep 2013 05:48:10 +0000
Message-ID: <52427938.4070602@freescale.com>
Date: Wed, 25 Sep 2013 13:48:40 +0800
From: Huang Shijie <b32955@freescale.com>
MIME-Version: 1.0
To: Sourav Poddar <sourav.poddar@ti.com>
Subject: Re: [PATCH] drivers: mtd: m25p80: Add quad read support.
References: <1380024647-18955-1-git-send-email-sourav.poddar@ti.com>
In-Reply-To: <1380024647-18955-1-git-send-email-sourav.poddar@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Cc: artem.bityutskiy@linux.intel.com, balbi@ti.com, broonie@kernel.org,
 linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
 dwmw2@infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

=E4=BA=8E 2013=E5=B9=B409=E6=9C=8824=E6=97=A5 20:10, Sourav Poddar =E5=86=
=99=E9=81=93:
> +	flash->quad_read =3D false;
> +	if (spi->mode&&  SPI_RX_QUAD) {
> +		quad_enable(flash);
> +		flash->mtd._read =3D m25p80_quad_read;
> +		flash->quad_read =3D true;
> +	} else
> +		flash->mtd._read =3D m25p80_read;
How do you know the NOR support the QUAD read? by the spi->mode?

i think you'd better add a DT node such as "m25p, quad-read".

thanks
Huang Shijie