From: Richard Weinberger <richard@nod.at>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] UBI: simplify image sequence test
Date: Fri, 27 Sep 2013 15:28:41 +0200 [thread overview]
Message-ID: <52458809.6050704@nod.at> (raw)
In-Reply-To: <1380286316-29911-2-git-send-email-richard.genoud@gmail.com>
Am 27.09.2013 14:51, schrieb Richard Genoud:
> The test:
> if (!a && b)
> a = b;
> can be symplified in:
> if (!a)
> a = b;
>
> And there's no need to test if ubi->image_seq is not null, because if it is,
> it is set to image_seq.
> So, we just test if image_seq is not null.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Acked-by: Richard Weinberger <richard@nod.at>
next prev parent reply other threads:[~2013-09-27 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 12:51 [PATCH] UBI: fastmap: fix backward compatibility with image_seq Richard Genoud
2013-09-27 12:51 ` [PATCH] UBI: simplify image sequence test Richard Genoud
2013-09-27 13:28 ` Richard Weinberger [this message]
2013-09-27 13:09 ` [PATCH] UBI: fastmap: fix backward compatibility with image_seq Richard Weinberger
2013-09-27 13:16 ` Richard Genoud
2013-09-27 13:21 ` Richard Weinberger
2013-09-27 14:53 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52458809.6050704@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox