From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bear.ext.ti.com ([192.94.94.41]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VX3HF-0001e9-PG for linux-mtd@lists.infradead.org; Fri, 18 Oct 2013 06:11:14 +0000 Message-ID: <5260D0C7.4000805@ti.com> Date: Fri, 18 Oct 2013 11:40:15 +0530 From: Sourav Poddar MIME-Version: 1.0 To: Trent Piepho Subject: Re: [PATCH 1/3] spi/qspi: Add memory mapped read support. References: <20131015111647.GX2443@sirena.org.uk> <525D2BB3.4020705@ti.com> <20131015124656.GM2443@sirena.org.uk> <525D41E2.30206@ti.com> <20131015180142.GS23337@ld-irv-0074.broadcom.com> <20980858CB6D3A4BAE95CA194937D5E73EA23640@DBDE04.ent.ti.com> <525FD715.50703@ti.com> <20131017123850.GN2443@sirena.org.uk> <20980858CB6D3A4BAE95CA194937D5E73EA27E10@DBDE04.ent.ti.com> <20131017234230.GZ2443@sirena.org.uk> <5260B3AE.9070308@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Korsgaard , "Balbi, Felipe" , Mark Brown , "linux-mtd@lists.infradead.org" , "Gupta, Pekon" , "spi-devel-general@lists.sourceforge.net" , Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 18 October 2013 11:26 AM, Trent Piepho wrote: > On Thu, Oct 17, 2013 at 9:06 PM, Sourav Poddar wrote: >> On Friday 18 October 2013 05:12 AM, Mark Brown wrote: >>>> Are you looking for comparison between read_via_dma() v/s memcpy() ? >>> No, I'm looking for a comparison of normal SPI mode (which I'd have >>> expected to DMA) and the memcpy() mode. >>> >>>> If yes, then unfortunately we are bit constrained because our controller >>>> does not support DMA. So, we have to depend on CPU based memcpy() >>>> only. However, use of DMA can be added as an independent patch on >>>> top of this CASE-2 patch. >>> However if the controller can't DMA at all then that's not going to be >>> possible... am I understanding you correctly that normal SPI can't DMA? >> Yes, you are correct, the normal SPI cant DMA. > Hardware limitation or driver limitation? Adding DMA support to the > driver might be much more useful than adding memory mapped read > support. Its a hardware limitation, the qspi controller does not support DMA.