linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Sourav Poddar <sourav.poddar@ti.com>
To: Huang Shijie <b32955@freescale.com>
Cc: marex@denx.de, computersforpeace@gmail.com,
	linux-mtd@lists.infradead.org, balbi@ti.com, dedekind1@gmail.com
Subject: Re: [Rebase/PATCHv2] drivers: mtd: m25p80: Add quad read support.
Date: Wed, 30 Oct 2013 15:02:59 +0530	[thread overview]
Message-ID: <5270D24B.5020800@ti.com> (raw)
In-Reply-To: <5270D16C.6030802@freescale.com>

Hi Huang,
On Wednesday 30 October 2013 02:59 PM, Huang Shijie wrote:
> 于 2013年10月30日 17:20, Sourav Poddar 写道:
>> @@ -1077,6 +1221,12 @@ static int m25p_probe(struct spi_device *spi)
>>           flash->addr_width = 4;
>>           if (JEDEC_MFR(info->jedec_id) == CFI_MFR_AMD) {
>>               /* Dedicated 4-byte command set */
>> +            if (flash->quad_read)
>> +                flash->read_opcode = OPCODE_QUAD_READ_4B;
>> +            else
>> +                flash->read_opcode = flash->fast_read ?
>> +                    OPCODE_FAST_READ_4B :
>> +                    OPCODE_NORM_READ_4B;
>>               flash->read_opcode = flash->fast_read ?
>>                   OPCODE_FAST_READ_4B :
>>                   OPCODE_NORM_READ_4B;
> you missed to remove these three lines above?
My bad. its removed in my internal testing branch. While rebasing,
I made some error. I will update the patch and send v3.

Thanks Huang for your review. if you have any other comments, it will be 
great to
know, so that I can consolidate all in v3 and send.

Thanks!
>
> thanks
> Huang Shijie
>

  reply	other threads:[~2013-10-30  9:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30  9:20 [Rebase/PATCHv2] drivers: mtd: m25p80: Add quad read support Sourav Poddar
2013-10-30  9:29 ` Huang Shijie
2013-10-30  9:32   ` Sourav Poddar [this message]
2013-10-30 10:18 ` Huang Shijie
2013-10-30 10:19   ` Sourav Poddar
2013-10-30 10:25     ` Huang Shijie
2013-10-30 13:38       ` Marek Vasut
2013-10-30 23:19 ` Brian Norris
2013-10-31  5:01   ` Sourav Poddar
2013-10-31 16:05     ` Brian Norris
2013-11-02  5:48       ` Sourav Poddar
2013-11-05  3:49         ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5270D24B.5020800@ti.com \
    --to=sourav.poddar@ti.com \
    --cc=b32955@freescale.com \
    --cc=balbi@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).