From: Huang Shijie <b32955@freescale.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: marex@denx.de, dedekind1@gmail.com, balbi@ti.com,
Mark Brown <broonie@kernel.org>,
linux-mtd@lists.infradead.org, computersforpeace@gmail.com
Subject: Re: [Rebase/PATCHv2] drivers: mtd: m25p80: Add quad read support.
Date: Wed, 30 Oct 2013 18:18:52 +0800 [thread overview]
Message-ID: <5270DD0C.2090902@freescale.com> (raw)
In-Reply-To: <1383124802-25079-1-git-send-email-sourav.poddar@ti.com>
于 2013年10月30日 17:20, Sourav Poddar 写道:
> @@ -1051,6 +1184,15 @@ static int m25p_probe(struct spi_device *spi)
> flash->page_size = info->page_size;
> flash->mtd.writebufsize = flash->page_size;
>
> + if (spi->mode& SPI_RX_QUAD&& info->flags& M25P80_QUAD_READ) {
> + ret = set_quad_mode(flash, info->jedec_id);
> + if (ret) {
> + dev_err(&flash->spi->dev, "quad mode not supported\n");
> + return ret;
> + }
> + flash->quad_read = true;
> + }
Do we really need the M25P80_QUAD_READ?
Some NOR flash can supports both the QUAD read and DDR QUAD read, while
some NOR flash only supports the
QUAD read.
when we try to add the DDR QUAD READ support, should we add another
flag, such as M25P80_DDR_QUAD_READ?
Add Mark for this email.
I think you'd better CC this patch to the SPI maillist & Mark,.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-10-30 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 9:20 [Rebase/PATCHv2] drivers: mtd: m25p80: Add quad read support Sourav Poddar
2013-10-30 9:29 ` Huang Shijie
2013-10-30 9:32 ` Sourav Poddar
2013-10-30 10:18 ` Huang Shijie [this message]
2013-10-30 10:19 ` Sourav Poddar
2013-10-30 10:25 ` Huang Shijie
2013-10-30 13:38 ` Marek Vasut
2013-10-30 23:19 ` Brian Norris
2013-10-31 5:01 ` Sourav Poddar
2013-10-31 16:05 ` Brian Norris
2013-11-02 5:48 ` Sourav Poddar
2013-11-05 3:49 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5270DD0C.2090902@freescale.com \
--to=b32955@freescale.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).