From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, grygorii.strashko@ti.com,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
gregkh@linuxfoundation.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@kernel.crashing.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Rob Landley <rob@landley.net>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] memory: ti-aemif: add bindings for AEMIF driver
Date: Wed, 20 Nov 2013 21:03:06 +0200 [thread overview]
Message-ID: <528D076A.8070806@ti.com> (raw)
In-Reply-To: <20131120182102.GK14627@ns203013.ovh.net>
On 11/20/2013 08:21 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> + the chip select signal.
>> + Minimum value is 1 (0 treated as 1).
>> +
>> +- ti,cs-wsetup: write setup width, ns
>> + Time between the beginning of a memory cycle
>> + and the activation of write strobe.
>> + Minimum value is 1 (0 treated as 1).
>> +
>> +- ti,cs-wstrobe: write strobe width, ns
>> + Time between the activation and deactivation of
>> + the write strobe.
>> + Minimum value is 1 (0 treated as 1).
>> +
>> +- ti,cs-whold: write hold width, ns
>> + Time between the deactivation of the write
>> + strobe and the end of the cycle (which may be
>> + either an address change or the deactivation of
>> + the chip select signal.
>> + Minimum value is 1 (0 treated as 1).
>> +
>> +If any of the above parameters are absent, current parameter value will be taken
>> +from the corresponding HW reg.
>> +
>> +The name for cs node must be in format csN, where N is the cs number.
>
> this is wired we should use reg instead to represent the cs as done for SPI
> or a an other property
>
> Best Regards,
> J.
>
Ok, I will add new property cs-chipselect like following :
ti,cs-chipselect: number of chipselect. Indicates on the
aemif driver which chipselect is used
for accessing the memory.
For compatibles "ti,davinci-aemif" and
"ti,keystone-aemif" it can be in range [0-3].
For compatible "ti,omap-L138-aemif" range is [2-5].
Is it OK?
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2013-11-20 19:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 15:46 [PATCH 0/2] Introduce AEMIF driver for Davinci/Keystone archs Ivan Khoronzhuk
2013-11-20 15:46 ` [PATCH 1/2] memory: ti-aemif: introduce AEMIF driver Ivan Khoronzhuk
2013-11-29 15:32 ` Santosh Shilimkar
2013-11-29 15:35 ` Grygorii Strashko
2013-11-29 15:43 ` Santosh Shilimkar
2013-12-03 10:49 ` ivan.khoronzhuk
2013-11-20 15:46 ` [PATCH 2/2] memory: ti-aemif: add bindings for " Ivan Khoronzhuk
2013-11-20 18:21 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 19:03 ` ivan.khoronzhuk [this message]
2013-11-22 18:42 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-29 14:56 ` Grygorii Strashko
2013-11-29 15:08 ` Santosh Shilimkar
2013-11-22 21:06 ` Kumar Gala
2013-11-26 17:23 ` ivan.khoronzhuk
2013-11-29 15:00 ` Grygorii Strashko
2013-11-29 15:10 ` Santosh Shilimkar
2013-12-03 10:50 ` ivan.khoronzhuk
2013-11-22 21:04 ` Kumar Gala
2013-11-26 16:27 ` Grygorii Strashko
2013-12-09 16:35 ` Santosh Shilimkar
2013-12-09 23:09 ` Kumar Gala
2013-12-10 10:40 ` ivan.khoronzhuk
2013-11-26 16:38 ` ivan.khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528D076A.8070806@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).