From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from comal.ext.ti.com ([198.47.26.152]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VlzIo-0000YJ-UN for linux-mtd@lists.infradead.org; Thu, 28 Nov 2013 10:58:35 +0000 Message-ID: <529721BF.4010902@ti.com> Date: Thu, 28 Nov 2013 16:28:07 +0530 From: Sourav Poddar MIME-Version: 1.0 To: Mark Brown Subject: Re: [PATCH 03/17] spi/qspi: parse register by name. References: <1385451313-1875-1-git-send-email-sourav.poddar@ti.com> <1385451313-1875-4-git-send-email-sourav.poddar@ti.com> <20131126103029.GY14725@sirena.org.uk> <5294835D.5090902@ti.com> <20131126122442.GC14725@sirena.org.uk> <5296CA5A.90304@ti.com> <20131128105423.GL14725@sirena.org.uk> In-Reply-To: <20131128105423.GL14725@sirena.org.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, computersforpeace@gmail.com, balbi@ti.com, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, bcousson@baylibre.com, linux-omap@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thursday 28 November 2013 04:24 PM, Mark Brown wrote: > On Thu, Nov 28, 2013 at 10:15:14AM +0530, Sourav Poddar wrote: >> On Tuesday 26 November 2013 05:54 PM, Mark Brown wrote: >>> Do device tree binding changes early on in the series rather than at the >>> end, one of the things that gets reviewed for is binding updates. >>> Your code should also cope with the existing bindings, falling back on >>> the current behaviour if it can't get the names or the extra resources. >> My current code only has a single resouce, hence "*_byname* variants >> was not used. With extra resources, I am switching to "byname" variants, >> So, if a particular resource name is not found, it should just >> bypass that, thinking >> the resource is not required and should not resort to existing bindings.. > That means that if you switch all resources to _byname then the driver > won't find any resources at all and will fail. This will in turn mean > that any device trees that work with the current code wil start failing, > breaking compatibility. I am changing my code to use *byname for all resources. There is no dts available now in mainline using this code. I have added the dts file as patch 15, 16 of this series to take care of this.