* [PATCH 01/23] mtd: atmel_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
@ 2013-12-26 3:00 ` Jingoo Han
2013-12-27 6:55 ` Josh Wu
2013-12-26 3:00 ` [PATCH 02/23] mtd: orion_nand: " Jingoo Han
` (22 subsequent siblings)
23 siblings, 1 reply; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:00 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Josh Wu'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/atmel_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 59f08c4..e633c44 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1961,10 +1961,8 @@ static int atmel_nand_probe(struct platform_device *pdev)
/* Allocate memory for the device structure (and zero it) */
host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
- if (!host) {
- printk(KERN_ERR "atmel_nand: failed to allocate device structure.\n");
+ if (!host)
return -ENOMEM;
- }
res = platform_driver_register(&atmel_nand_nfc_driver);
if (res)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 01/23] mtd: atmel_nand: Remove unnecessary OOM messages
2013-12-26 3:00 ` [PATCH 01/23] mtd: atmel_nand: " Jingoo Han
@ 2013-12-27 6:55 ` Josh Wu
0 siblings, 0 replies; 32+ messages in thread
From: Josh Wu @ 2013-12-27 6:55 UTC (permalink / raw)
To: Jingoo Han, 'Brian Norris'; +Cc: linux-mtd, 'David Woodhouse'
On 12/26/2013 11:00 AM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Josh Wu <josh.wu@atmel.com>
Best Regards,
Josh Wu
> ---
> drivers/mtd/nand/atmel_nand.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 59f08c4..e633c44 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -1961,10 +1961,8 @@ static int atmel_nand_probe(struct platform_device *pdev)
>
> /* Allocate memory for the device structure (and zero it) */
> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - printk(KERN_ERR "atmel_nand: failed to allocate device structure.\n");
> + if (!host)
> return -ENOMEM;
> - }
>
> res = platform_driver_register(&atmel_nand_nfc_driver);
> if (res)
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 02/23] mtd: orion_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
2013-12-26 3:00 ` [PATCH 01/23] mtd: atmel_nand: " Jingoo Han
@ 2013-12-26 3:00 ` Jingoo Han
2013-12-26 3:01 ` [PATCH 03/23] mtd: sharpsl: " Jingoo Han
` (21 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:00 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Andrew Lunn'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/orion_nand.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
index a393a5b..a6a4a20 100644
--- a/drivers/mtd/nand/orion_nand.c
+++ b/drivers/mtd/nand/orion_nand.c
@@ -87,7 +87,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
nc = kzalloc(sizeof(struct nand_chip) + sizeof(struct mtd_info), GFP_KERNEL);
if (!nc) {
- printk(KERN_ERR "orion_nand: failed to allocate device structure.\n");
ret = -ENOMEM;
goto no_res;
}
@@ -110,7 +109,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
board = devm_kzalloc(&pdev->dev, sizeof(struct orion_nand_data),
GFP_KERNEL);
if (!board) {
- printk(KERN_ERR "orion_nand: failed to allocate board structure.\n");
ret = -ENOMEM;
goto no_res;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 03/23] mtd: sharpsl: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
2013-12-26 3:00 ` [PATCH 01/23] mtd: atmel_nand: " Jingoo Han
2013-12-26 3:00 ` [PATCH 02/23] mtd: orion_nand: " Jingoo Han
@ 2013-12-26 3:01 ` Jingoo Han
2013-12-26 3:02 ` [PATCH 04/23] mtd: au1550nd: " Jingoo Han
` (20 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:01 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/sharpsl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c
index 87908d7..61a85ab 100644
--- a/drivers/mtd/nand/sharpsl.c
+++ b/drivers/mtd/nand/sharpsl.c
@@ -121,10 +121,8 @@ static int sharpsl_nand_probe(struct platform_device *pdev)
/* Allocate memory for MTD device structure and private data */
sharpsl = kzalloc(sizeof(struct sharpsl_nand), GFP_KERNEL);
- if (!sharpsl) {
- printk("Unable to allocate SharpSL NAND MTD device structure.\n");
+ if (!sharpsl)
return -ENOMEM;
- }
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!r) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 04/23] mtd: au1550nd: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (2 preceding siblings ...)
2013-12-26 3:01 ` [PATCH 03/23] mtd: sharpsl: " Jingoo Han
@ 2013-12-26 3:02 ` Jingoo Han
2013-12-26 3:04 ` [PATCH 05/23] mtd: bf5xx_nand: " Jingoo Han
` (19 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:02 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/au1550nd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/au1550nd.c b/drivers/mtd/nand/au1550nd.c
index 909b673..2880d88 100644
--- a/drivers/mtd/nand/au1550nd.c
+++ b/drivers/mtd/nand/au1550nd.c
@@ -418,10 +418,8 @@ static int au1550nd_probe(struct platform_device *pdev)
}
ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
- if (!ctx) {
- dev_err(&pdev->dev, "no memory for NAND context\n");
+ if (!ctx)
return -ENOMEM;
- }
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!r) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 05/23] mtd: bf5xx_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (3 preceding siblings ...)
2013-12-26 3:02 ` [PATCH 04/23] mtd: au1550nd: " Jingoo Han
@ 2013-12-26 3:04 ` Jingoo Han
2013-12-26 7:53 ` Mike Frysinger
2013-12-26 3:04 ` [PATCH 06/23] mtd: cafe_nand: " Jingoo Han
` (18 subsequent siblings)
23 siblings, 1 reply; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:04 UTC (permalink / raw)
To: 'Brian Norris'
Cc: 'Mike Frysinger', linux-mtd, 'Jingoo Han',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/bf5xx_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/bf5xx_nand.c b/drivers/mtd/nand/bf5xx_nand.c
index 2c42e12..94f55db 100644
--- a/drivers/mtd/nand/bf5xx_nand.c
+++ b/drivers/mtd/nand/bf5xx_nand.c
@@ -745,7 +745,6 @@ static int bf5xx_nand_probe(struct platform_device *pdev)
info = kzalloc(sizeof(*info), GFP_KERNEL);
if (info == NULL) {
- dev_err(&pdev->dev, "no memory for flash info\n");
err = -ENOMEM;
goto out_err_kzalloc;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 06/23] mtd: cafe_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (4 preceding siblings ...)
2013-12-26 3:04 ` [PATCH 05/23] mtd: bf5xx_nand: " Jingoo Han
@ 2013-12-26 3:04 ` Jingoo Han
2013-12-26 3:06 ` [PATCH 07/23] mtd: cmx270_nand: " Jingoo Han
` (17 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:04 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/cafe_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/cafe_nand.c b/drivers/mtd/nand/cafe_nand.c
index c34985a..f2f64ad 100644
--- a/drivers/mtd/nand/cafe_nand.c
+++ b/drivers/mtd/nand/cafe_nand.c
@@ -640,10 +640,8 @@ static int cafe_nand_probe(struct pci_dev *pdev,
pci_set_master(pdev);
mtd = kzalloc(sizeof(*mtd) + sizeof(struct cafe_priv), GFP_KERNEL);
- if (!mtd) {
- dev_warn(&pdev->dev, "failed to alloc mtd_info\n");
+ if (!mtd)
return -ENOMEM;
- }
cafe = (void *)(&mtd[1]);
mtd->dev.parent = &pdev->dev;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 07/23] mtd: cmx270_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (5 preceding siblings ...)
2013-12-26 3:04 ` [PATCH 06/23] mtd: cafe_nand: " Jingoo Han
@ 2013-12-26 3:06 ` Jingoo Han
2013-12-26 3:06 ` [PATCH 08/23] mtd: cs553x_nand: " Jingoo Han
` (16 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:06 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Mike Rapoport'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/cmx270_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/cmx270_nand.c b/drivers/mtd/nand/cmx270_nand.c
index 39b2ef8..66ec95e 100644
--- a/drivers/mtd/nand/cmx270_nand.c
+++ b/drivers/mtd/nand/cmx270_nand.c
@@ -164,7 +164,6 @@ static int __init cmx270_init(void)
sizeof(struct nand_chip),
GFP_KERNEL);
if (!cmx270_nand_mtd) {
- pr_debug("Unable to allocate CM-X270 NAND MTD device structure.\n");
ret = -ENOMEM;
goto err_kzalloc;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 08/23] mtd: cs553x_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (6 preceding siblings ...)
2013-12-26 3:06 ` [PATCH 07/23] mtd: cmx270_nand: " Jingoo Han
@ 2013-12-26 3:06 ` Jingoo Han
2013-12-26 3:07 ` [PATCH 09/23] mtd: diskonchip: " Jingoo Han
` (15 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:06 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/cs553x_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/cs553x_nand.c b/drivers/mtd/nand/cs553x_nand.c
index d469a9a..88109d3 100644
--- a/drivers/mtd/nand/cs553x_nand.c
+++ b/drivers/mtd/nand/cs553x_nand.c
@@ -199,7 +199,6 @@ static int __init cs553x_init_one(int cs, int mmio, unsigned long adr)
/* Allocate memory for MTD device structure and private data */
new_mtd = kzalloc(sizeof(struct mtd_info) + sizeof(struct nand_chip), GFP_KERNEL);
if (!new_mtd) {
- printk(KERN_WARNING "Unable to allocate CS553X NAND MTD device structure.\n");
err = -ENOMEM;
goto out;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 09/23] mtd: diskonchip: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (7 preceding siblings ...)
2013-12-26 3:06 ` [PATCH 08/23] mtd: cs553x_nand: " Jingoo Han
@ 2013-12-26 3:07 ` Jingoo Han
2013-12-26 3:08 ` [PATCH 10/23] mtd: fsl_elbc_nand: " Jingoo Han
` (14 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:07 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/diskonchip.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c
index 0afafa0..fec31d7 100644
--- a/drivers/mtd/nand/diskonchip.c
+++ b/drivers/mtd/nand/diskonchip.c
@@ -1058,7 +1058,6 @@ static inline int __init nftl_partscan(struct mtd_info *mtd, struct mtd_partitio
buf = kmalloc(mtd->writesize, GFP_KERNEL);
if (!buf) {
- printk(KERN_ERR "DiskOnChip mediaheader kmalloc failed!\n");
return 0;
}
if (!(numheaders = find_media_headers(mtd, buf, "ANAND", 1)))
@@ -1166,7 +1165,6 @@ static inline int __init inftl_partscan(struct mtd_info *mtd, struct mtd_partiti
buf = kmalloc(mtd->writesize, GFP_KERNEL);
if (!buf) {
- printk(KERN_ERR "DiskOnChip mediaheader kmalloc failed!\n");
return 0;
}
@@ -1564,7 +1562,6 @@ static int __init doc_probe(unsigned long physadr)
sizeof(struct nand_chip) + sizeof(struct doc_priv) + (2 * sizeof(struct nand_bbt_descr));
mtd = kzalloc(len, GFP_KERNEL);
if (!mtd) {
- printk(KERN_ERR "DiskOnChip kmalloc (%d bytes) failed!\n", len);
ret = -ENOMEM;
goto fail;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 10/23] mtd: fsl_elbc_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (8 preceding siblings ...)
2013-12-26 3:07 ` [PATCH 09/23] mtd: diskonchip: " Jingoo Han
@ 2013-12-26 3:08 ` Jingoo Han
2013-12-26 3:09 ` [PATCH 11/23] mtd: fsl_ifc_nand: " Jingoo Han
` (13 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:08 UTC (permalink / raw)
To: 'Brian Norris'
Cc: 'Scott Wood', linux-mtd, 'Jingoo Han',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/fsl_elbc_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index c966fc7..d32f1d3 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -847,7 +847,6 @@ static int fsl_elbc_nand_probe(struct platform_device *pdev)
if (!fsl_lbc_ctrl_dev->nand) {
elbc_fcm_ctrl = kzalloc(sizeof(*elbc_fcm_ctrl), GFP_KERNEL);
if (!elbc_fcm_ctrl) {
- dev_err(dev, "failed to allocate memory\n");
mutex_unlock(&fsl_elbc_nand_mutex);
ret = -ENOMEM;
goto err;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 11/23] mtd: fsl_ifc_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (9 preceding siblings ...)
2013-12-26 3:08 ` [PATCH 10/23] mtd: fsl_elbc_nand: " Jingoo Han
@ 2013-12-26 3:09 ` Jingoo Han
2013-12-26 3:09 ` [PATCH 12/23] mtd: jz4740_nand: " Jingoo Han
` (12 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:09 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Prabhakar Kushwaha'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/fsl_ifc_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index 4335577..3344080 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -1060,7 +1060,6 @@ static int fsl_ifc_nand_probe(struct platform_device *dev)
if (!fsl_ifc_ctrl_dev->nand) {
ifc_nand_ctrl = kzalloc(sizeof(*ifc_nand_ctrl), GFP_KERNEL);
if (!ifc_nand_ctrl) {
- dev_err(&dev->dev, "failed to allocate memory\n");
mutex_unlock(&fsl_ifc_nand_mutex);
return -ENOMEM;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 12/23] mtd: jz4740_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (10 preceding siblings ...)
2013-12-26 3:09 ` [PATCH 11/23] mtd: fsl_ifc_nand: " Jingoo Han
@ 2013-12-26 3:09 ` Jingoo Han
2013-12-26 3:11 ` [PATCH 13/23] mtd: pasemi_nand: " Jingoo Han
` (11 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:09 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/jz4740_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/jz4740_nand.c b/drivers/mtd/nand/jz4740_nand.c
index a264b88..a2c804d 100644
--- a/drivers/mtd/nand/jz4740_nand.c
+++ b/drivers/mtd/nand/jz4740_nand.c
@@ -416,10 +416,8 @@ static int jz_nand_probe(struct platform_device *pdev)
uint8_t nand_maf_id = 0, nand_dev_id = 0;
nand = kzalloc(sizeof(*nand), GFP_KERNEL);
- if (!nand) {
- dev_err(&pdev->dev, "Failed to allocate device structure.\n");
+ if (!nand)
return -ENOMEM;
- }
ret = jz_nand_ioremap_resource(pdev, "mmio", &nand->mem, &nand->base);
if (ret)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 13/23] mtd: pasemi_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (11 preceding siblings ...)
2013-12-26 3:09 ` [PATCH 12/23] mtd: jz4740_nand: " Jingoo Han
@ 2013-12-26 3:11 ` Jingoo Han
2013-12-27 5:43 ` Olof Johansson
2013-12-26 3:12 ` [PATCH 14/23] mtd: txx9ndfmc: " Jingoo Han
` (10 subsequent siblings)
23 siblings, 1 reply; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:11 UTC (permalink / raw)
To: 'Brian Norris'
Cc: 'Olof Johansson', linux-mtd, 'Jingoo Han',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/pasemi_nand.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
index 90f871a..24cf045 100644
--- a/drivers/mtd/nand/pasemi_nand.c
+++ b/drivers/mtd/nand/pasemi_nand.c
@@ -114,8 +114,6 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
pasemi_nand_mtd = kzalloc(sizeof(struct mtd_info) +
sizeof(struct nand_chip), GFP_KERNEL);
if (!pasemi_nand_mtd) {
- printk(KERN_WARNING
- "Unable to allocate PASEMI NAND MTD device structure\n");
err = -ENOMEM;
goto out;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 13/23] mtd: pasemi_nand: Remove unnecessary OOM messages
2013-12-26 3:11 ` [PATCH 13/23] mtd: pasemi_nand: " Jingoo Han
@ 2013-12-27 5:43 ` Olof Johansson
2013-12-27 5:49 ` Jingoo Han
0 siblings, 1 reply; 32+ messages in thread
From: Olof Johansson @ 2013-12-27 5:43 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-mtd@lists.infradead.org, Brian Norris, David Woodhouse
On Wed, Dec 25, 2013 at 7:11 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Actually -- the pasemi platform is barely used these days, and the
users I am aware of do not use the nand driver. I think we'd just fine
with removing it. I'll submit a patch to do so instead.
-Olof
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 13/23] mtd: pasemi_nand: Remove unnecessary OOM messages
2013-12-27 5:43 ` Olof Johansson
@ 2013-12-27 5:49 ` Jingoo Han
0 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-27 5:49 UTC (permalink / raw)
To: 'Brian Norris'
Cc: 'Olof Johansson', linux-mtd, 'Jingoo Han',
'David Woodhouse'
On Friday, December 27, 2013 2:43 PM, Olof Johansson wrote:
> On Wed, Dec 25, 2013 at 7:11 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> > The site-specific OOM messages are unnecessary, because they
> > duplicate the MM subsystem generic OOM message.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Actually -- the pasemi platform is barely used these days, and the
> users I am aware of do not use the nand driver. I think we'd just fine
> with removing it. I'll submit a patch to do so instead.
Brian Norris,
Please ignore this patch, because the pasemi nand driver will
be removed by Olof Johansson. Thank you.
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 14/23] mtd: txx9ndfmc: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (12 preceding siblings ...)
2013-12-26 3:11 ` [PATCH 13/23] mtd: pasemi_nand: " Jingoo Han
@ 2013-12-26 3:12 ` Jingoo Han
2013-12-26 3:13 ` [PATCH 15/23] mtd: davinci_nand: " Jingoo Han
` (9 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:12 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Atsushi Nemoto', 'Jingoo Han',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/txx9ndfmc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/txx9ndfmc.c b/drivers/mtd/nand/txx9ndfmc.c
index 235714a..c1622a5 100644
--- a/drivers/mtd/nand/txx9ndfmc.c
+++ b/drivers/mtd/nand/txx9ndfmc.c
@@ -319,11 +319,8 @@ static int __init txx9ndfmc_probe(struct platform_device *dev)
continue;
txx9_priv = kzalloc(sizeof(struct txx9ndfmc_priv),
GFP_KERNEL);
- if (!txx9_priv) {
- dev_err(&dev->dev, "Unable to allocate "
- "TXx9 NDFMC MTD device structure.\n");
+ if (!txx9_priv)
continue;
- }
chip = &txx9_priv->chip;
mtd = &txx9_priv->mtd;
mtd->owner = THIS_MODULE;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 15/23] mtd: davinci_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (13 preceding siblings ...)
2013-12-26 3:12 ` [PATCH 14/23] mtd: txx9ndfmc: " Jingoo Han
@ 2013-12-26 3:13 ` Jingoo Han
2013-12-26 3:16 ` [PATCH 16/23] mtd: fsmc_nand: " Jingoo Han
` (8 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:13 UTC (permalink / raw)
To: 'Brian Norris'
Cc: 'Grygorii Strashko', 'Jingoo Han',
'Taras Kondratiuk', linux-mtd, 'Ivan Khoronzhuk',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/davinci_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index 0104d26..a4989ec 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -619,10 +619,8 @@ static int nand_davinci_probe(struct platform_device *pdev)
return -ENODEV;
info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
- if (!info) {
- dev_err(&pdev->dev, "unable to allocate memory\n");
+ if (!info)
return -ENOMEM;
- }
platform_set_drvdata(pdev, info);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 16/23] mtd: fsmc_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (14 preceding siblings ...)
2013-12-26 3:13 ` [PATCH 15/23] mtd: davinci_nand: " Jingoo Han
@ 2013-12-26 3:16 ` Jingoo Han
2014-01-07 17:55 ` Linus Walleij
2013-12-26 3:17 ` [PATCH 17/23] mtd: nand-gpio: " Jingoo Han
` (7 subsequent siblings)
23 siblings, 1 reply; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:16 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Linus Walleij', 'Jingoo Han',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/fsmc_nand.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
index 8b27522..a5915f1 100644
--- a/drivers/mtd/nand/fsmc_nand.c
+++ b/drivers/mtd/nand/fsmc_nand.c
@@ -889,10 +889,8 @@ static int fsmc_nand_probe_config_dt(struct platform_device *pdev,
pdata->nand_timings = devm_kzalloc(&pdev->dev,
sizeof(*pdata->nand_timings), GFP_KERNEL);
- if (!pdata->nand_timings) {
- dev_err(&pdev->dev, "no memory for nand_timing\n");
+ if (!pdata->nand_timings)
return -ENOMEM;
- }
of_property_read_u8_array(np, "timings", (u8 *)pdata->nand_timings,
sizeof(*pdata->nand_timings));
@@ -950,10 +948,8 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
/* Allocate memory for the device structure (and zero it) */
host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
- if (!host) {
- dev_err(&pdev->dev, "failed to allocate device structure\n");
+ if (!host)
return -ENOMEM;
- }
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "nand_data");
host->data_va = devm_ioremap_resource(&pdev->dev, res);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 17/23] mtd: nand-gpio: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (15 preceding siblings ...)
2013-12-26 3:16 ` [PATCH 16/23] mtd: fsmc_nand: " Jingoo Han
@ 2013-12-26 3:17 ` Jingoo Han
2013-12-26 3:18 ` [PATCH 18/23] mtd: lpc32xx_mlc: " Jingoo Han
` (6 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:17 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Alexander Shiyan', 'Mike Rapoport'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/gpio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
index e826f89..8dfdbb6 100644
--- a/drivers/mtd/nand/gpio.c
+++ b/drivers/mtd/nand/gpio.c
@@ -211,10 +211,8 @@ static int gpio_nand_probe(struct platform_device *pdev)
return -EINVAL;
gpiomtd = devm_kzalloc(&pdev->dev, sizeof(*gpiomtd), GFP_KERNEL);
- if (!gpiomtd) {
- dev_err(&pdev->dev, "failed to create NAND MTD\n");
+ if (!gpiomtd)
return -ENOMEM;
- }
chip = &gpiomtd->nand_chip;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 18/23] mtd: lpc32xx_mlc: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (16 preceding siblings ...)
2013-12-26 3:17 ` [PATCH 17/23] mtd: nand-gpio: " Jingoo Han
@ 2013-12-26 3:18 ` Jingoo Han
2013-12-26 10:30 ` Roland Stigge
2013-12-26 3:18 ` [PATCH 19/23] mtd: lpc32xx_slc: " Jingoo Han
` (5 subsequent siblings)
23 siblings, 1 reply; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:18 UTC (permalink / raw)
To: 'Brian Norris'
Cc: 'Roland Stigge', linux-mtd, 'Jingoo Han',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/lpc32xx_mlc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
index 48be850..687478c 100644
--- a/drivers/mtd/nand/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/lpc32xx_mlc.c
@@ -613,10 +613,8 @@ static struct lpc32xx_nand_cfg_mlc *lpc32xx_parse_dt(struct device *dev)
struct device_node *np = dev->of_node;
ncfg = devm_kzalloc(dev, sizeof(*ncfg), GFP_KERNEL);
- if (!ncfg) {
- dev_err(dev, "could not allocate memory for platform data\n");
+ if (!ncfg)
return NULL;
- }
of_property_read_u32(np, "nxp,tcea-delay", &ncfg->tcea_delay);
of_property_read_u32(np, "nxp,busy-delay", &ncfg->busy_delay);
@@ -652,10 +650,8 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
/* Allocate memory for the device structure (and zero it) */
host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
- if (!host) {
- dev_err(&pdev->dev, "failed to allocate device structure.\n");
+ if (!host)
return -ENOMEM;
- }
rc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host->io_base = devm_ioremap_resource(&pdev->dev, rc);
@@ -750,14 +746,12 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
host->dma_buf = devm_kzalloc(&pdev->dev, mtd->writesize, GFP_KERNEL);
if (!host->dma_buf) {
- dev_err(&pdev->dev, "Error allocating dma_buf memory\n");
res = -ENOMEM;
goto err_exit3;
}
host->dummy_buf = devm_kzalloc(&pdev->dev, mtd->writesize, GFP_KERNEL);
if (!host->dummy_buf) {
- dev_err(&pdev->dev, "Error allocating dummy_buf memory\n");
res = -ENOMEM;
goto err_exit3;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 18/23] mtd: lpc32xx_mlc: Remove unnecessary OOM messages
2013-12-26 3:18 ` [PATCH 18/23] mtd: lpc32xx_mlc: " Jingoo Han
@ 2013-12-26 10:30 ` Roland Stigge
0 siblings, 0 replies; 32+ messages in thread
From: Roland Stigge @ 2013-12-26 10:30 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-mtd, 'Brian Norris', 'David Woodhouse'
On 26/12/13 04:18, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Roland Stigge <stigge@antcom.de>
> ---
> drivers/mtd/nand/lpc32xx_mlc.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
> index 48be850..687478c 100644
> --- a/drivers/mtd/nand/lpc32xx_mlc.c
> +++ b/drivers/mtd/nand/lpc32xx_mlc.c
> @@ -613,10 +613,8 @@ static struct lpc32xx_nand_cfg_mlc *lpc32xx_parse_dt(struct device *dev)
> struct device_node *np = dev->of_node;
>
> ncfg = devm_kzalloc(dev, sizeof(*ncfg), GFP_KERNEL);
> - if (!ncfg) {
> - dev_err(dev, "could not allocate memory for platform data\n");
> + if (!ncfg)
> return NULL;
> - }
>
> of_property_read_u32(np, "nxp,tcea-delay", &ncfg->tcea_delay);
> of_property_read_u32(np, "nxp,busy-delay", &ncfg->busy_delay);
> @@ -652,10 +650,8 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
>
> /* Allocate memory for the device structure (and zero it) */
> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - dev_err(&pdev->dev, "failed to allocate device structure.\n");
> + if (!host)
> return -ENOMEM;
> - }
>
> rc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> host->io_base = devm_ioremap_resource(&pdev->dev, rc);
> @@ -750,14 +746,12 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
>
> host->dma_buf = devm_kzalloc(&pdev->dev, mtd->writesize, GFP_KERNEL);
> if (!host->dma_buf) {
> - dev_err(&pdev->dev, "Error allocating dma_buf memory\n");
> res = -ENOMEM;
> goto err_exit3;
> }
>
> host->dummy_buf = devm_kzalloc(&pdev->dev, mtd->writesize, GFP_KERNEL);
> if (!host->dummy_buf) {
> - dev_err(&pdev->dev, "Error allocating dummy_buf memory\n");
> res = -ENOMEM;
> goto err_exit3;
> }
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 19/23] mtd: lpc32xx_slc: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (17 preceding siblings ...)
2013-12-26 3:18 ` [PATCH 18/23] mtd: lpc32xx_mlc: " Jingoo Han
@ 2013-12-26 3:18 ` Jingoo Han
2013-12-26 10:30 ` Roland Stigge
2013-12-26 3:19 ` [PATCH 20/23] mtd: mpc5121_nfc: " Jingoo Han
` (4 subsequent siblings)
23 siblings, 1 reply; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:18 UTC (permalink / raw)
To: 'Brian Norris'
Cc: 'Roland Stigge', linux-mtd, 'Jingoo Han',
'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/lpc32xx_slc.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
index 5f20394..53a6742 100644
--- a/drivers/mtd/nand/lpc32xx_slc.c
+++ b/drivers/mtd/nand/lpc32xx_slc.c
@@ -725,10 +725,8 @@ static struct lpc32xx_nand_cfg_slc *lpc32xx_parse_dt(struct device *dev)
struct device_node *np = dev->of_node;
ncfg = devm_kzalloc(dev, sizeof(*ncfg), GFP_KERNEL);
- if (!ncfg) {
- dev_err(dev, "could not allocate memory for NAND config\n");
+ if (!ncfg)
return NULL;
- }
of_property_read_u32(np, "nxp,wdr-clks", &ncfg->wdr_clks);
of_property_read_u32(np, "nxp,wwidth", &ncfg->wwidth);
@@ -772,10 +770,8 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
/* Allocate memory for the device structure (and zero it) */
host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
- if (!host) {
- dev_err(&pdev->dev, "failed to allocate device structure\n");
+ if (!host)
return -ENOMEM;
- }
host->io_base_dma = rc->start;
host->io_base = devm_ioremap_resource(&pdev->dev, rc);
@@ -858,7 +854,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
host->data_buf = devm_kzalloc(&pdev->dev, host->dma_buf_len,
GFP_KERNEL);
if (host->data_buf == NULL) {
- dev_err(&pdev->dev, "Error allocating memory\n");
res = -ENOMEM;
goto err_exit2;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 19/23] mtd: lpc32xx_slc: Remove unnecessary OOM messages
2013-12-26 3:18 ` [PATCH 19/23] mtd: lpc32xx_slc: " Jingoo Han
@ 2013-12-26 10:30 ` Roland Stigge
0 siblings, 0 replies; 32+ messages in thread
From: Roland Stigge @ 2013-12-26 10:30 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-mtd, 'Brian Norris', 'David Woodhouse'
On 26/12/13 04:18, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Roland Stigge <stigge@antcom.de>
> ---
> drivers/mtd/nand/lpc32xx_slc.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
> index 5f20394..53a6742 100644
> --- a/drivers/mtd/nand/lpc32xx_slc.c
> +++ b/drivers/mtd/nand/lpc32xx_slc.c
> @@ -725,10 +725,8 @@ static struct lpc32xx_nand_cfg_slc *lpc32xx_parse_dt(struct device *dev)
> struct device_node *np = dev->of_node;
>
> ncfg = devm_kzalloc(dev, sizeof(*ncfg), GFP_KERNEL);
> - if (!ncfg) {
> - dev_err(dev, "could not allocate memory for NAND config\n");
> + if (!ncfg)
> return NULL;
> - }
>
> of_property_read_u32(np, "nxp,wdr-clks", &ncfg->wdr_clks);
> of_property_read_u32(np, "nxp,wwidth", &ncfg->wwidth);
> @@ -772,10 +770,8 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
>
> /* Allocate memory for the device structure (and zero it) */
> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - dev_err(&pdev->dev, "failed to allocate device structure\n");
> + if (!host)
> return -ENOMEM;
> - }
> host->io_base_dma = rc->start;
>
> host->io_base = devm_ioremap_resource(&pdev->dev, rc);
> @@ -858,7 +854,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
> host->data_buf = devm_kzalloc(&pdev->dev, host->dma_buf_len,
> GFP_KERNEL);
> if (host->data_buf == NULL) {
> - dev_err(&pdev->dev, "Error allocating memory\n");
> res = -ENOMEM;
> goto err_exit2;
> }
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 20/23] mtd: mpc5121_nfc: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (18 preceding siblings ...)
2013-12-26 3:18 ` [PATCH 19/23] mtd: lpc32xx_slc: " Jingoo Han
@ 2013-12-26 3:19 ` Jingoo Han
2013-12-26 3:21 ` [PATCH 21/23] mtd: plat_nand: " Jingoo Han
` (3 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:19 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Gerhard Sittig', 'Jingoo Han',
'David Woodhouse', 'Anatolij Gustschin'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/mpc5121_nfc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c
index a244aaa..31ee7cf 100644
--- a/drivers/mtd/nand/mpc5121_nfc.c
+++ b/drivers/mtd/nand/mpc5121_nfc.c
@@ -653,10 +653,8 @@ static int mpc5121_nfc_probe(struct platform_device *op)
}
prv = devm_kzalloc(dev, sizeof(*prv), GFP_KERNEL);
- if (!prv) {
- dev_err(dev, "Memory exhausted!\n");
+ if (!prv)
return -ENOMEM;
- }
mtd = &prv->mtd;
chip = &prv->chip;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 21/23] mtd: plat_nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (19 preceding siblings ...)
2013-12-26 3:19 ` [PATCH 20/23] mtd: mpc5121_nfc: " Jingoo Han
@ 2013-12-26 3:21 ` Jingoo Han
2013-12-26 3:21 ` [PATCH 22/23] mtd: s3c2410: " Jingoo Han
` (2 subsequent siblings)
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:21 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Vitaly Wool'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/plat_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c
index 7734f0e..aa8eb9c 100644
--- a/drivers/mtd/nand/plat_nand.c
+++ b/drivers/mtd/nand/plat_nand.c
@@ -54,10 +54,8 @@ static int plat_nand_probe(struct platform_device *pdev)
/* Allocate memory for the device structure (and zero it) */
data = devm_kzalloc(&pdev->dev, sizeof(struct plat_nand_data),
GFP_KERNEL);
- if (!data) {
- dev_err(&pdev->dev, "failed to allocate device structure.\n");
+ if (!data)
return -ENOMEM;
- }
data->io_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(data->io_base))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 22/23] mtd: s3c2410: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (20 preceding siblings ...)
2013-12-26 3:21 ` [PATCH 21/23] mtd: plat_nand: " Jingoo Han
@ 2013-12-26 3:21 ` Jingoo Han
2013-12-26 3:22 ` [PATCH 23/23] mtd: sh_flctl: " Jingoo Han
2014-01-03 1:30 ` [PATCH 00/23] mtd: nand: " Brian Norris
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:21 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/s3c2410.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index d65cbe9..47fbd9a 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -919,7 +919,6 @@ static int s3c24xx_nand_probe(struct platform_device *pdev)
info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
if (info == NULL) {
- dev_err(&pdev->dev, "no memory for flash info\n");
err = -ENOMEM;
goto exit_error;
}
@@ -974,7 +973,6 @@ static int s3c24xx_nand_probe(struct platform_device *pdev)
size = nr_sets * sizeof(*info->mtds);
info->mtds = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
if (info->mtds == NULL) {
- dev_err(&pdev->dev, "failed to allocate mtd storage\n");
err = -ENOMEM;
goto exit_error;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 23/23] mtd: sh_flctl: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (21 preceding siblings ...)
2013-12-26 3:21 ` [PATCH 22/23] mtd: s3c2410: " Jingoo Han
@ 2013-12-26 3:22 ` Jingoo Han
2014-01-03 1:30 ` [PATCH 00/23] mtd: nand: " Brian Norris
23 siblings, 0 replies; 32+ messages in thread
From: Jingoo Han @ 2013-12-26 3:22 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/sh_flctl.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index 1940bd1..d72783d 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -1058,10 +1058,8 @@ static struct sh_flctl_platform_data *flctl_parse_dt(struct device *dev)
pdata = devm_kzalloc(dev, sizeof(struct sh_flctl_platform_data),
GFP_KERNEL);
- if (!pdata) {
- dev_err(dev, "%s: failed to allocate config data\n", __func__);
+ if (!pdata)
return NULL;
- }
/* set SoC specific options */
pdata->flcmncr_val = config->flcmncr_val;
@@ -1092,10 +1090,8 @@ static int flctl_probe(struct platform_device *pdev)
struct mtd_part_parser_data ppdata = {};
flctl = devm_kzalloc(&pdev->dev, sizeof(struct sh_flctl), GFP_KERNEL);
- if (!flctl) {
- dev_err(&pdev->dev, "failed to allocate driver data\n");
+ if (!flctl)
return -ENOMEM;
- }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
flctl->reg = devm_ioremap_resource(&pdev->dev, res);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages
2013-12-26 2:58 [PATCH 00/23] mtd: nand: Remove unnecessary OOM messages Jingoo Han
` (22 preceding siblings ...)
2013-12-26 3:22 ` [PATCH 23/23] mtd: sh_flctl: " Jingoo Han
@ 2014-01-03 1:30 ` Brian Norris
23 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-01-03 1:30 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-mtd, 'David Woodhouse'
On Thu, Dec 26, 2013 at 11:58:57AM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
>
> Jingoo Han (23):
> mtd: atmel_nand: Remove unnecessary OOM messages
> mtd: orion_nand: Remove unnecessary OOM messages
> mtd: sharpsl: Remove unnecessary OOM messages
> mtd: au1550nd: Remove unnecessary OOM messages
> mtd: bf5xx_nand: Remove unnecessary OOM messages
> mtd: cafe_nand: Remove unnecessary OOM messages
> mtd: cmx270_nand: Remove unnecessary OOM messages
> mtd: cs553x_nand: Remove unnecessary OOM messages
> mtd: diskonchip: Remove unnecessary OOM messages
> mtd: fsl_elbc_nand: Remove unnecessary OOM messages
> mtd: fsl_ifc_nand: Remove unnecessary OOM messages
> mtd: jz4740_nand: Remove unnecessary OOM messages
> mtd: pasemi_nand: Remove unnecessary OOM messages
> mtd: txx9ndfmc: Remove unnecessary OOM messages
> mtd: davinci_nand: Remove unnecessary OOM messages
> mtd: fsmc_nand: Remove unnecessary OOM messages
> mtd: nand-gpio: Remove unnecessary OOM messages
> mtd: lpc32xx_mlc: Remove unnecessary OOM messages
> mtd: lpc32xx_slc: Remove unnecessary OOM messages
> mtd: mpc5121_nfc: Remove unnecessary OOM messages
> mtd: plat_nand: Remove unnecessary OOM messages
> mtd: s3c2410: Remove unnecessary OOM messages
> mtd: sh_flctl: Remove unnecessary OOM messages
Pushed all but patch 21 (plat_nand; it had dependencies on a previous
patch that I skipped) to l2-mtd.git. Thanks.
Brian
^ permalink raw reply [flat|nested] 32+ messages in thread