* [PATCH V2 1/4] mtd: atmel_nand: use dev_err() instead of printk()
2013-12-26 3:29 [PATCH 0/4] mtd: nan: use dev_err() instead of printk() Jingoo Han
@ 2013-12-26 3:30 ` Jingoo Han
2013-12-27 6:56 ` Josh Wu
2013-12-26 3:31 ` [PATCH V2 2/4] mtd: fsmc_nand: use dev_warn() " Jingoo Han
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Jingoo Han @ 2013-12-26 3:30 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Josh Wu'
Use dev_err() instead of printk() to provide a better message
to userspace.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Change since v1
- Remove the site-specific OOM messages.
drivers/mtd/nand/atmel_nand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index e633c44..c36e9b8 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -2060,14 +2060,14 @@ static int atmel_nand_probe(struct platform_device *pdev)
}
if (gpio_get_value(host->board.det_pin)) {
- printk(KERN_INFO "No SmartMedia card inserted.\n");
+ dev_info(&pdev->dev, "No SmartMedia card inserted.\n");
res = -ENXIO;
goto err_no_card;
}
}
if (host->board.on_flash_bbt || on_flash_bbt) {
- printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
+ dev_info(&pdev->dev, "Use On Flash BBT\n");
nand_chip->bbt_options |= NAND_BBT_USE_FLASH;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH V2 1/4] mtd: atmel_nand: use dev_err() instead of printk()
2013-12-26 3:30 ` [PATCH V2 1/4] mtd: atmel_nand: " Jingoo Han
@ 2013-12-27 6:56 ` Josh Wu
0 siblings, 0 replies; 8+ messages in thread
From: Josh Wu @ 2013-12-27 6:56 UTC (permalink / raw)
To: Jingoo Han, 'Brian Norris'; +Cc: linux-mtd, 'David Woodhouse'
On 12/26/2013 11:30 AM, Jingoo Han wrote:
> Use dev_err() instead of printk() to provide a better message
> to userspace.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Josh Wu <josh.wu@atmel.com>
Best Regards,
Josh Wu
> ---
> Change since v1
> - Remove the site-specific OOM messages.
>
> drivers/mtd/nand/atmel_nand.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e633c44..c36e9b8 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2060,14 +2060,14 @@ static int atmel_nand_probe(struct platform_device *pdev)
> }
>
> if (gpio_get_value(host->board.det_pin)) {
> - printk(KERN_INFO "No SmartMedia card inserted.\n");
> + dev_info(&pdev->dev, "No SmartMedia card inserted.\n");
> res = -ENXIO;
> goto err_no_card;
> }
> }
>
> if (host->board.on_flash_bbt || on_flash_bbt) {
> - printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
> + dev_info(&pdev->dev, "Use On Flash BBT\n");
> nand_chip->bbt_options |= NAND_BBT_USE_FLASH;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2 2/4] mtd: fsmc_nand: use dev_warn() instead of printk()
2013-12-26 3:29 [PATCH 0/4] mtd: nan: use dev_err() instead of printk() Jingoo Han
2013-12-26 3:30 ` [PATCH V2 1/4] mtd: atmel_nand: " Jingoo Han
@ 2013-12-26 3:31 ` Jingoo Han
2014-01-07 17:56 ` Linus Walleij
2013-12-26 3:31 ` [PATCH V2 3/4] mtd: orion_nand: use dev_err() " Jingoo Han
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Jingoo Han @ 2013-12-26 3:31 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Linus Walleij', 'Jingoo Han',
'David Woodhouse'
Use dev_warn() instead of printk() to provide a better message
to userspace.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
No changes since v1.
drivers/mtd/nand/fsmc_nand.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
index a5915f1..1550692 100644
--- a/drivers/mtd/nand/fsmc_nand.c
+++ b/drivers/mtd/nand/fsmc_nand.c
@@ -1104,8 +1104,8 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
host->ecc_place = &fsmc_ecc4_lp_place;
break;
default:
- printk(KERN_WARNING "No oob scheme defined for "
- "oobsize %d\n", mtd->oobsize);
+ dev_warn(&pdev->dev, "No oob scheme defined for oobsize %d\n",
+ mtd->oobsize);
BUG();
}
} else {
@@ -1120,8 +1120,8 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
nand->ecc.layout = &fsmc_ecc1_128_layout;
break;
default:
- printk(KERN_WARNING "No oob scheme defined for "
- "oobsize %d\n", mtd->oobsize);
+ dev_warn(&pdev->dev, "No oob scheme defined for oobsize %d\n",
+ mtd->oobsize);
BUG();
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH V2 3/4] mtd: orion_nand: use dev_err() instead of printk()
2013-12-26 3:29 [PATCH 0/4] mtd: nan: use dev_err() instead of printk() Jingoo Han
2013-12-26 3:30 ` [PATCH V2 1/4] mtd: atmel_nand: " Jingoo Han
2013-12-26 3:31 ` [PATCH V2 2/4] mtd: fsmc_nand: use dev_warn() " Jingoo Han
@ 2013-12-26 3:31 ` Jingoo Han
2013-12-26 3:32 ` [PATCH V2 4/4] mtd: sharpsl: " Jingoo Han
2014-01-03 18:26 ` [PATCH 0/4] mtd: nan: " Brian Norris
4 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-26 3:31 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse',
'Andrew Lunn'
Use dev_err() instead of printk() to provide a better message
to userspace.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Change since v1
- Remove the site-specific OOM messages.
drivers/mtd/nand/orion_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
index a6a4a20..dd7fe81 100644
--- a/drivers/mtd/nand/orion_nand.c
+++ b/drivers/mtd/nand/orion_nand.c
@@ -100,7 +100,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
io_base = ioremap(res->start, resource_size(res));
if (!io_base) {
- printk(KERN_ERR "orion_nand: ioremap failed\n");
+ dev_err(&pdev->dev, "ioremap failed\n");
ret = -EIO;
goto no_res;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH V2 4/4] mtd: sharpsl: use dev_err() instead of printk()
2013-12-26 3:29 [PATCH 0/4] mtd: nan: use dev_err() instead of printk() Jingoo Han
` (2 preceding siblings ...)
2013-12-26 3:31 ` [PATCH V2 3/4] mtd: orion_nand: use dev_err() " Jingoo Han
@ 2013-12-26 3:32 ` Jingoo Han
2014-01-03 18:26 ` [PATCH 0/4] mtd: nan: " Brian Norris
4 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-26 3:32 UTC (permalink / raw)
To: 'Brian Norris'
Cc: linux-mtd, 'Jingoo Han', 'David Woodhouse'
Use dev_err() instead of printk() to provide a better message
to userspace.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Change since v1
- Remove the site-specific OOM messages.
drivers/mtd/nand/sharpsl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c
index 61a85ab..e81059b 100644
--- a/drivers/mtd/nand/sharpsl.c
+++ b/drivers/mtd/nand/sharpsl.c
@@ -134,7 +134,7 @@ static int sharpsl_nand_probe(struct platform_device *pdev)
/* map physical address */
sharpsl->io = ioremap(r->start, resource_size(r));
if (!sharpsl->io) {
- printk("ioremap to access Sharp SL NAND chip failed\n");
+ dev_err(&pdev->dev, "ioremap to access Sharp SL NAND chip failed\n");
err = -EIO;
goto err_ioremap;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 0/4] mtd: nan: use dev_err() instead of printk()
2013-12-26 3:29 [PATCH 0/4] mtd: nan: use dev_err() instead of printk() Jingoo Han
` (3 preceding siblings ...)
2013-12-26 3:32 ` [PATCH V2 4/4] mtd: sharpsl: " Jingoo Han
@ 2014-01-03 18:26 ` Brian Norris
4 siblings, 0 replies; 8+ messages in thread
From: Brian Norris @ 2014-01-03 18:26 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Lunn', 'Linus Walleij', 'Josh Wu',
linux-mtd, 'Ezequiel Garcia', 'David Woodhouse'
On Thu, Dec 26, 2013 at 12:29:48PM +0900, Jingoo Han wrote:
> Use dev_err()/dev_warn() instead of printk() to provide a better
> message to userspace.
>
> Change since v1
> - Remove the site-specific OOM messages, per Ezequiel Garcia.
>
> Jingoo Han (4)
> mtd: atmel_nand: use dev_err() instead of printk()
> mtd: fsmc_nand: use dev_warn() instead of printk()
> mtd: orion_nand: use dev_err() instead of printk()
> mtd: sharpsl: use dev_err() instead of printk()
Pushed all 4 to l2-mtd.git. Thanks.
Brian
^ permalink raw reply [flat|nested] 8+ messages in thread