Re: [PATCH 1/1] ubi: Introduce block devices for UBI volumes

[Richard Weinberger <richard@nod.at>]

Am 10.02.2014 15:20, schrieb Ezequiel Garcia:
> On Mon, Feb 10, 2014 at 09:46:16AM +0100, Willy Tarreau wrote:
>>>>
>>>> If write support has 0 or 1.5 customers and it was not tested
>>>> extensively, and never used in any kind of production, I am not sure it
>>>> is needed to be there. But let's first hear your answers.
>>>>
>>>
>>> No, this hasn't been tested intensively and I'm pretty sure nobody would
>>> ever put it in production before conducting such tests himself.
>>
>> For sure, but conversely, disabling it in the code would result in
>> nobody ever testing it !
>>
> 
> I agree completely and it's why I wanted to have it available.
> 
>>>
>>> If you really think distros will enable it and users will "just it", without
>>> thinking about the consequences, then I'd say let's just remove it.
>>
>> In my opinion, this would result in users falling back to mtdblock as
>> they currently to when they want a block device. This is even worse.
>>
>> I'd really like to have this feature as a standard one, it shortens
>> the gap which exists between MTD and eMMC which is becoming more and
>> more common these days, precisely because of the difficulty to deal
>> with NAND directly while eMMC provides the abstraction which offers
>> more flexibility.
>>
> 
> Artem, I'd say it's your call. Want me to drop write support or not?
> 
> Unfortunately, I don't have enough time to conduct extensive testings on
> that, but just simple read/write test on some filesystem as Willy did on
> ext2

Please, at lest run xfstests. :)

> Quite frankly, I want to see this merged as soon as possible, so if we
> are still having second thoughts, I'll submit a read-only version and
> we'll see about adding write support later.
> 

If you have addressed the issues I pointed out feel free to add
Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard