* [PATCH 15/28] Remove TI_AEMIF
[not found] <1391971686-9517-1-git-send-email-richard@nod.at>
@ 2014-02-09 18:47 ` Richard Weinberger
2014-02-09 20:54 ` Paul Bolle
0 siblings, 1 reply; 4+ messages in thread
From: Richard Weinberger @ 2014-02-09 18:47 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, open list:MEMORY TECHNOLOGY...,
open list
Cc: Richard Weinberger
The symbol is an orphan, get rid of it.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/nand/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 90ff447..a195d57 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -465,7 +465,7 @@ config MTD_NAND_SH_FLCTL
config MTD_NAND_DAVINCI
tristate "Support NAND on DaVinci/Keystone SoC"
- depends on ARCH_DAVINCI || (ARCH_KEYSTONE && TI_AEMIF)
+ depends on ARCH_DAVINCI || ARCH_KEYSTONE
help
Enable the driver for NAND flash chips on Texas Instruments
DaVinci/Keystone processors.
--
1.8.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 15/28] Remove TI_AEMIF
2014-02-09 18:47 ` [PATCH 15/28] Remove TI_AEMIF Richard Weinberger
@ 2014-02-09 20:54 ` Paul Bolle
2014-02-11 19:04 ` Brian Norris
0 siblings, 1 reply; 4+ messages in thread
From: Paul Bolle @ 2014-02-09 20:54 UTC (permalink / raw)
To: Richard Weinberger
Cc: open list:MEMORY TECHNOLOGY..., Brian Norris, David Woodhouse,
open list
On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote:
> The symbol is an orphan, get rid of it.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 90ff447..a195d57 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -465,7 +465,7 @@ config MTD_NAND_SH_FLCTL
>
> config MTD_NAND_DAVINCI
> tristate "Support NAND on DaVinci/Keystone SoC"
> - depends on ARCH_DAVINCI || (ARCH_KEYSTONE && TI_AEMIF)
> + depends on ARCH_DAVINCI || ARCH_KEYSTONE
> help
> Enable the driver for NAND flash chips on Texas Instruments
> DaVinci/Keystone processors.
What's strange about the current dependency is that the only aemif code
I could find lives at arch/arm/mach-davinci/aemif.c. Is that reachable
for code in arch/arm/mach-keystone?
Paul Bolle
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 15/28] Remove TI_AEMIF
2014-02-09 20:54 ` Paul Bolle
@ 2014-02-11 19:04 ` Brian Norris
2014-02-11 19:42 ` Ivan Khoronzhuk
0 siblings, 1 reply; 4+ messages in thread
From: Brian Norris @ 2014-02-11 19:04 UTC (permalink / raw)
To: Paul Bolle
Cc: Richard Weinberger, open list, Santosh Shilimkar, Ivan Khoronzhuk,
open list:MEMORY TECHNOLOGY..., David Woodhouse
+ Ivan, others
On Sun, Feb 09, 2014 at 09:54:02PM +0100, Paul Bolle wrote:
> On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote:
> > The symbol is an orphan, get rid of it.
> >
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> > ---
> > drivers/mtd/nand/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > index 90ff447..a195d57 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -465,7 +465,7 @@ config MTD_NAND_SH_FLCTL
> >
> > config MTD_NAND_DAVINCI
> > tristate "Support NAND on DaVinci/Keystone SoC"
> > - depends on ARCH_DAVINCI || (ARCH_KEYSTONE && TI_AEMIF)
> > + depends on ARCH_DAVINCI || ARCH_KEYSTONE
> > help
> > Enable the driver for NAND flash chips on Texas Instruments
> > DaVinci/Keystone processors.
>
> What's strange about the current dependency is that the only aemif code
> I could find lives at arch/arm/mach-davinci/aemif.c. Is that reachable
> for code in arch/arm/mach-keystone?
It looks like I merged this code before the supporting aemif driver [1] was
merged. I think this is harmless, and so I plan to leave it as-is for
now. Or if Ivan prefers, I can drop the Keystone dependency entirely
until it is ready.
https://lkml.org/lkml/2013/11/20/283
Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 15/28] Remove TI_AEMIF
2014-02-11 19:04 ` Brian Norris
@ 2014-02-11 19:42 ` Ivan Khoronzhuk
0 siblings, 0 replies; 4+ messages in thread
From: Ivan Khoronzhuk @ 2014-02-11 19:42 UTC (permalink / raw)
To: Brian Norris, Paul Bolle
Cc: Richard Weinberger, Santosh Shilimkar, David Woodhouse, open list,
open list:MEMORY TECHNOLOGY...
On 02/11/2014 09:04 PM, Brian Norris wrote:
> + Ivan, others
>
> On Sun, Feb 09, 2014 at 09:54:02PM +0100, Paul Bolle wrote:
>> On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote:
>>> The symbol is an orphan, get rid of it.
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> drivers/mtd/nand/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>>> index 90ff447..a195d57 100644
>>> --- a/drivers/mtd/nand/Kconfig
>>> +++ b/drivers/mtd/nand/Kconfig
>>> @@ -465,7 +465,7 @@ config MTD_NAND_SH_FLCTL
>>>
>>> config MTD_NAND_DAVINCI
>>> tristate "Support NAND on DaVinci/Keystone SoC"
>>> - depends on ARCH_DAVINCI || (ARCH_KEYSTONE && TI_AEMIF)
>>> + depends on ARCH_DAVINCI || ARCH_KEYSTONE
>>> help
>>> Enable the driver for NAND flash chips on Texas Instruments
>>> DaVinci/Keystone processors.
>> What's strange about the current dependency is that the only aemif code
>> I could find lives at arch/arm/mach-davinci/aemif.c. Is that reachable
>> for code in arch/arm/mach-keystone?
> It looks like I merged this code before the supporting aemif driver [1] was
> merged. I think this is harmless, and so I plan to leave it as-is for
> now. Or if Ivan prefers, I can drop the Keystone dependency entirely
> until it is ready.
>
> https://lkml.org/lkml/2013/11/20/283
>
> Brian
It is harmless.
For Keystone NAND depends on AEMIF.
AEMIF is responsible to set timings.
In case of Davinci the timings are set by arch/arm/mach-davinci/aemif.c.
In case of Keystone the timings are going to be set by AEMIF driver.
AEMIF is going to be merged I hope. That's plan.
So you can leave it.
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-11 19:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1391971686-9517-1-git-send-email-richard@nod.at>
2014-02-09 18:47 ` [PATCH 15/28] Remove TI_AEMIF Richard Weinberger
2014-02-09 20:54 ` Paul Bolle
2014-02-11 19:04 ` Brian Norris
2014-02-11 19:42 ` Ivan Khoronzhuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).