From: Kyungmin Park <kyungmin.park@samsung.com>
To: Artem Bityutskiy <dedekind@infradead.org>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Adrian Hunter <ext-adrian.hunter@nokia.com>
Subject: OneNAND: Always print error messages
Date: Wed, 17 Jan 2007 23:57:07 +0000 (GMT) [thread overview]
Message-ID: <5309548.532541169078227711.JavaMail.weblogic@ep_ml22> (raw)
Hi Artem,
> Yeah, it indeed makes few sense to print out error message if we meet a
> bad block. But being silent when errors occur is bad as well.
I agree
> > I'm not sure how to handle error message, especillay at onenand_wait().
> > controller error is very important but it's too verbose at boot time.
> We can avoid doing this if (1) we cannot read OOB (1) and we are
> scanning (2). In other cases we print the error message. Comments?
Yes, simple solution is separate read oob from normal and scanning.
I think is is easy because we can use state variable, FL_SCANNING instead of FL_READING in bbt.
I will try it.
Thank you,
Kyungmin Park
next reply other threads:[~2007-01-17 23:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 23:57 Kyungmin Park [this message]
2007-01-18 1:34 ` OneNAND: Always print error messages Artem Bityutskiy
2007-01-18 16:24 ` Adrian Hunter
-- strict thread matches above, loose matches on Subject: below --
2007-01-19 8:21 Kyungmin Park
2007-01-19 8:58 ` Adrian Hunter
2007-01-19 7:14 Kyungmin Park
2007-01-19 8:02 ` Adrian Hunter
2007-01-12 6:48 Kyungmin Park
2007-01-17 23:14 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5309548.532541169078227711.JavaMail.weblogic@ep_ml22 \
--to=kyungmin.park@samsung.com \
--cc=dedekind@infradead.org \
--cc=ext-adrian.hunter@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox