Re: OneNAND: Always print error messages

Artem Bityutskiy
2007-01-17T23:14:42Z

On Fri, 2007-01-12 at 06:48 +0000, Kyungmin Park wrote:
> As you know, nand flash has several initial bad blocks.
> Maybe many uses don't like to see the some error message at boot time.

Yeah, it indeed makes few sense to print out error message if we meet a
bad block. But being silent when errors occur is bad as well.

> At least, onenand_wait(), onenand_do_read_oob() have to change from
KERN_ERR to KERN_DEBUG

KERN_ERR and KERN_DEBUG are just printk priorities. I would better say
"printk to DEBUG()".

> I'm not sure how to handle error message, especillay at onenand_wait().
> controller error is very important but it's too verbose at boot time.

We can avoid doing this if (1) we cannot read OOB (1) and we are
scanning (2). In other cases we print the error message. Comments?

--
Best regards,
Artem Bityutskiy