From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: fsl-quadspi: fix __iomem annotations
Date: Wed, 16 Apr 2014 16:54:00 +0800 [thread overview]
Message-ID: <534E4528.6030700@freescale.com> (raw)
In-Reply-To: <1397638079-1894-1-git-send-email-computersforpeace@gmail.com>
于 2014年04月16日 16:47, Brian Norris 写道:
> This corrects some sparse warnings:
>
> drivers/mtd/spi-nor/fsl-quadspi.c:281:31: warning: incorrect type in initializer (different address spaces) [sparse]
> drivers/mtd/spi-nor/fsl-quadspi.c:281:31: expected void *[noderef] <asn:2>base [sparse]
> drivers/mtd/spi-nor/fsl-quadspi.c:281:31: got void [noderef] <asn:2>*iobase [sparse]
> (etc.)
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> Branched off of a previous patch series, but dropped the memcpy() stuff for now
>
> drivers/mtd/spi-nor/fsl-quadspi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index b41bbbc531ff..8d659a2888d5 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -278,7 +278,7 @@ static irqreturn_t fsl_qspi_irq_handler(int irq, void *dev_id)
>
> static void fsl_qspi_init_lut(struct fsl_qspi *q)
> {
> - void *__iomem base = q->iobase;
> + void __iomem *base = q->iobase;
> int rxfifo = q->devtype_data->rxfifo;
> u32 lut_base;
> u8 cmd, addrlen, dummy;
> @@ -422,7 +422,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
> static int
> fsl_qspi_runcmd(struct fsl_qspi *q, u8 cmd, unsigned int addr, int len)
> {
> - void *__iomem base = q->iobase;
> + void __iomem *base = q->iobase;
> int seqid;
> u32 reg, reg2;
> int err;
Acked-by: Huang Shijie <b32955@freescale.com>
next prev parent reply other threads:[~2014-04-16 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 8:47 [PATCH] mtd: fsl-quadspi: fix __iomem annotations Brian Norris
2014-04-16 8:54 ` Huang Shijie [this message]
2014-04-16 9:15 ` Brian Norris
2014-04-16 9:21 ` Huang Shijie
2014-04-17 5:13 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E4528.6030700@freescale.com \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox