From: John Crispin <john@phrozen.org>
To: dedekind1@gmail.com, Luka Perkov <luka@openwrt.org>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH] UBI: add a ubi forced detach ioctl
Date: Tue, 13 May 2014 11:09:42 +0200 [thread overview]
Message-ID: <5371E156.1090200@phrozen.org> (raw)
In-Reply-To: <1399971821.1797.24.camel@sauron.fi.intel.com>
On 13/05/2014 11:03, Artem Bityutskiy wrote:
> On Mon, 2014-05-12 at 12:44 +0200, Luka Perkov wrote:
>> When running ubi rootfs upgrade on nand based OpenWrt device
>> after pivot_root init process is still "hooked" on the old file
>> system. Thus, the old file system can not be umounted. If the
>> filesystem is mounted it can not be upgraded with using for
>> example ubiupdatevol or removed with ubirmvol. Forcing umount
>> would allow to run the before mentioned commands.
>
> Generally, a change like this may be fine, but I'd like to see
> more detailed description and analysis, which points to how other
> kernel subsystems deal with this.
>
Hi Artem,
agreed, this patch is an interim hack we did to make a new piece of
code work that helps us to sysupgrade the ubi when a new openwrt
release is flashed. this tool is far from complete and is still
missing a lot of details. once we are done and know if this patch
makes sense in its current form we will let you know and resend this
or an alternate patch with a proper description.
Would that be ok with you ?
John
prev parent reply other threads:[~2014-05-13 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 23:17 [PATCH] UBI: add a ubi forced detach ioctl Luka Perkov
2014-05-12 7:14 ` Richard Weinberger
2014-05-12 9:21 ` John Crispin
2014-05-12 10:44 ` Luka Perkov
2014-05-12 13:47 ` Richard Weinberger
2014-05-12 14:30 ` Luka Perkov
2014-05-13 9:03 ` Artem Bityutskiy
2014-05-13 9:09 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5371E156.1090200@phrozen.org \
--to=john@phrozen.org \
--cc=blogic@openwrt.org \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=luka@openwrt.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox