Re: [PATCH] mtd: atmel_nand: make ecc parameters same as definition

[Bo Shen <voice.shen@atmel.com>]

Hi Nicolas,

On 06/12/2014 03:26 PM, Nicolas Ferre wrote:
> On 12/06/2014 09:20, Josh Wu :
>> Hi, Bo
>>
>> On 6/11/2014 11:24 AM, Bo Shen wrote:
>>> Hi Josh,
>>>
>>> On 06/09/2014 06:30 PM, Josh Wu wrote:
>>>> Hi, Bo
>>>>
>>>> Thanks for the patch.
>>>>
>>>> On 6/6/2014 4:02 PM, Bo Shen wrote:
>>>>> If the ecc parameter is not the same as definition, when the
>>>>> mtd core check these parameters, it will give the unexpected
>>>>> result.
>>>> Could you be more specific to tell what kind of result will happened?
>>>
>>> For example:
>>> When try to calculate how many bits can correct in one page according
>>> to the definition, it will give the wrong result.
>>>
>>> one page correct bits = (mtd->writesize * ecc->strength) / ecc->size;
>>>
>>> take the following use case as an example:
>>> mtd->writesize = 2048 bytes,
>>> ecc->strength = 4 bytes, (for 512 bytes)
>>>
>>> before this patch, the ecc->size = 2048, so the result is 4 bytes.
>>>
>>> after this patch, the ecc->size = 512, so the result is 16 bytes.
>>>
>>> The maximum correct bytes is 16 bytes while not 4 bytes. So, if not align
>>
>> That is clear enough, thanks. The patch is fine to me. so
>> Acked-by: Josh Wu <josh.wu@atmel.com>
>
> So I advice to add this additional information to the commit message:
> Can you send a v2 with enhanced commit message.

OK, no problem.

> Thanks, bye,
>

Best Regards,
Bo Shen