From: Heiko Schocher <hs@denx.de>
To: Richard Weinberger <richard@nod.at>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
linux-mtd@lists.infradead.org
Subject: Re: UBI: fix rb_tree node comparison in add_map commit buggy?
Date: Mon, 23 Jun 2014 15:05:13 +0200 [thread overview]
Message-ID: <53A82609.9090408@denx.de> (raw)
In-Reply-To: <53A82077.6090109@nod.at>
Hello Richard,
Am 23.06.2014 14:41, schrieb Richard Weinberger:
> Am 23.06.2014 13:04, schrieb Heiko Schocher:
>> I tried this patch also in the U-Boot code, without getting a ubifs
>> rootfs (burned with u-boot into the ubi volume) bootable in linux ...
>> which worked before... maybe v3.14 and v3.16-rc1 are not compatible?
>> Do anybody know from such problems?
>>
>> If I revert commit 604b592e6fd3c98f21435e1181ba7723ffc24715 in
>> Linux v3.16-rc1 only (so I have the same code in U-Boot at this
>> place), I can boot Linux with the ubifs based rootfs, and after
>> a reboot the U-Boot ubi attach time is short ... all works fine,
>> as I can see it ...
>>
>> If I make in U-Boot and Linux in following patch [1]:
>> $ git diff
>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
>> index b04e7d0..72f39da 100644
>> --- a/drivers/mtd/ubi/fastmap.c
>> +++ b/drivers/mtd/ubi/fastmap.c
>> @@ -125,7 +125,7 @@ static struct ubi_ainf_volume *add_vol(struct ubi_attach_info *ai, int vol_id,
>> parent = *p;
>> av = rb_entry(parent, struct ubi_ainf_volume, rb);
>>
>> - if (vol_id< av->vol_id)
>> + if (vol_id> av->vol_id)
>> p =&(*p)->rb_left;
>> else
>> p =&(*p)->rb_right;
>> $
>
> "Found" your patch. ;)
> Looks like I need new glasses.
;-)
> Yes, it looks correct as the logic is now balanced with the logic in ubi_find_av().
Ah, yes, right! So should I post a correct patch for this?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-06-23 13:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53A7EF04.7040805@denx.de>
[not found] ` <53A809A3.30703@denx.de>
2014-06-23 11:58 ` UBI: fix rb_tree node comparison in add_map commit buggy? Richard Weinberger
2014-06-23 12:41 ` Richard Weinberger
2014-06-23 13:05 ` Heiko Schocher [this message]
2014-06-23 19:07 ` Richard Weinberger
2014-06-24 4:59 ` Artem Bityutskiy
2014-06-24 5:26 ` Heiko Schocher
2014-06-24 5:31 ` Artem Bityutskiy
2014-06-24 6:52 ` Richard Weinberger
2014-06-24 6:53 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A82609.9090408@denx.de \
--to=hs@denx.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).