From: hujianyang <hujianyang@huawei.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] UBIFS: fix fatal race condition
Date: Mon, 30 Jun 2014 10:22:03 +0800 [thread overview]
Message-ID: <53B0C9CB.8080208@huawei.com> (raw)
In-Reply-To: <1404051371-29756-2-git-send-email-dedekind1@gmail.com>
Hi Artem,
It's better than mine. I've tested some cases to reproduce this race
and found "> c->max_bud_bytes" is mostly hit in add_bud_to_log() but
'< c->min_log_bytes' is hardly hit. I think this race condition merely
occur and power cut frequently must be one of reasons.
Our fixes harm the performance a bit. Other process should wait for
write_mst_node() done before writing a new bud even if this commit is
not triggered by log lebs full. I don't know how to avoid this but
I think current version is enough. Flash is very fast.
I would like to test these patches now and report to you soon.
Thanks a lot!
Hu
prev parent reply other threads:[~2014-06-30 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 14:16 [PATCH v2 1/2] UBIFS: remove mst_mutex Artem Bityutskiy
2014-06-29 14:16 ` [PATCH v2 2/2] UBIFS: fix fatal race condition Artem Bityutskiy
2014-06-30 2:22 ` hujianyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B0C9CB.8080208@huawei.com \
--to=hujianyang@huawei.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox