From: Varka Bhadram <varkabhadram@gmail.com>
To: Martin Fuzzey <mfuzzey@parkeon.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] mtd: add driver for the flash in Lattice machxo2 FPGAs
Date: Fri, 25 Jul 2014 14:07:33 +0530 [thread overview]
Message-ID: <53D2174D.80909@gmail.com> (raw)
In-Reply-To: <53D20F51.2090705@parkeon.com>
On 07/25/2014 01:33 PM, Martin Fuzzey wrote:
(...)
> +
>>> +static void machxo2_lock(struct machxo2 *machxo2)
>>> +{
>>> + if (!mutex_trylock(&machxo2->lock)) {
>>> + dev_dbg(machxo2->dev, "wait for %s from %pf\n",
>>> + __func__, __builtin_return_address(0));
>>> +
>>
>> dev_dbg(machxo2->dev, "wait for %s from %pf\n",
>> __func__, __builtin_return_address(0));
>>
>
> Sorry, not understanding here.
> You want the second line to be LESS intented??
>
> Coding style (chapter 2) says:
> Descendants are always substantially shorter than the parent and
> are placed substantially to the right
>
> Idem for the others
this is the problem with my email client sorry.. 2nd line should start exactly
below 'm' in machxo2->dev...
dev_dbg(machxo2->dev, "wait for %s from %pf\n",
__func__, __builtin_return_address(0));
>
>> +static int machxo2_transceive(
>>> + struct machxo2 *machxo2,
>>> + const void *send_buf, unsigned send_len,
>>> + void *recv_buf, unsigned recv_len)
>>
(...)
>>> +struct machxo2 *machxo2_create(struct device *dev,
>>> + struct machxo2_busops *busops);
>>> +
>>
>> struct machxo2 *machxo2_create(struct device *dev,
>> struct machxo2_busops *busops);
>>
>>
> Same again - is it just too much indenting?
> I don't see anything wrong here
>
same...
--
Regards,
Varka Bhadram.
prev parent reply other threads:[~2014-07-25 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 16:22 [PATCH] mtd: add driver for the flash in Lattice machxo2 FPGAs Martin Fuzzey
2014-07-25 4:11 ` Varka Bhadram
2014-07-25 8:03 ` Martin Fuzzey
2014-07-25 8:37 ` Varka Bhadram [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2174D.80909@gmail.com \
--to=varkabhadram@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mfuzzey@parkeon.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).