Re: [PATCH v2] ubifs: refactor ubifs_file_mmap()

[Zhang Zhen <zhenzhang.zhang@huawei.com>]

On 2014/7/29 0:25, Artem Bityutskiy wrote:
> On Tue, 2014-07-22 at 14:28 +0800, Zhang Zhen wrote:
>> generic_file_mmap() set vma->vm_ops = &generic_file_vm_ops,
>> then ubifs_file_mmap set vma->vm_ops = &ubifs_file_vm_ops.
>> So it is redundant.
>> And there is no kind of file does not supply page reading function
>> in ubifs. The readpage() check up for mmap file in generic_file_mmap()
>> is not needed.
>>
>> So remove the call of generic_file_mmap().
>>
>> Change v1 -> v2:
>> - deleted the mapping variable
>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
> 
> Hi, I am not sure about this patch. 'generic_file_mmap()' covers !
> CONFIG_MMU case too, for example.
> 
Yes, I missed that. We can add #ifdef CONFIG_MMU in ubifs_file_mmap().
Considering the patch itself is not important changes, we can give up
this patch, remain the same.

What do you think?

Thanks for your comments!
> Thanks!
>