From: pekon <pekon@pek-sem.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Roger Quadros <rogerq@ti.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Brian Norris" <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
"Guido Martínez" <guido@vanguardiasur.com.ar>
Subject: Re: [PATCH 2/3] nand: omap2: Remove horrible ifdefs to fix module probe
Date: Thu, 11 Sep 2014 01:45:15 +0530 [thread overview]
Message-ID: <5410B153.80303@pek-sem.com> (raw)
In-Reply-To: <20140910124849.GA25308@arch.hh.imgtec.org>
On Wednesday 10 September 2014 06:18 PM, Ezequiel Garcia wrote:
> On 08 Sep 01:53 PM, Roger Quadros wrote:
>> On 09/08/2014 11:45 AM, Roger Quadros wrote:
>>> On 09/06/2014 10:56 PM, Ezequiel Garcia wrote:
> [..]
>>>> diff --git a/include/linux/platform_data/elm.h b/include/linux/platform_data/elm.h
>>>> index 780d1e9..25d1bca 100644
>>>> --- a/include/linux/platform_data/elm.h
>>>> +++ b/include/linux/platform_data/elm.h
>>>> @@ -42,8 +42,22 @@ struct elm_errorvec {
>>>> int error_loc[16];
>>>> };
>>>>
>>>> +#if IS_ENABLED(CONFIG_MTD_NAND_OMAP_BCH)
>>
>> I still get the following error if I set CONFIG_MTD_NAND_OMAP2 to y and
>> CONFIG_MTD_NAND_OMAP_BCH to m.
>>
>> CONFIG_MTD_NAND_OMAP_BCH is used to select the ELM driver and it must be limited to
>> be built-in if CONFIG_MTD_NAND_OMAP2 is built-in.
>>
>
> Hm, yup. Any ideas on how to accomplish that? My Kconfig-foo is not strong enough :(
>
>
Does following work ?
config MTD_NAND_OMAP_BCH
depends on MTD_NAND_OMAP2
tristate "<message>" if (MTD_NAND_OMAP2 && m)
bool "<message>" if (MTD_NAND_OMAP2 && y)
default n
...
Sorry, I don't have tools to check myself. If not following should help:
$KERNEL/Documentation/kbuild/kconfig-language.txt
with regards, pekon
------------------------
Powered by BigRock.com
next prev parent reply other threads:[~2014-09-10 20:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 19:56 [PATCH 0/3] nand: omap2: Two and a half improvements Ezequiel Garcia
2014-09-06 19:56 ` [PATCH 1/3] nand: omap2: Add support for a flash-based bad block table Ezequiel Garcia
2014-09-06 19:56 ` [PATCH 2/3] nand: omap2: Remove horrible ifdefs to fix module probe Ezequiel Garcia
2014-09-06 21:10 ` pekon
2014-09-06 21:47 ` Ezequiel Garcia
2014-09-06 23:17 ` Ezequiel Garcia
2014-09-07 9:35 ` pekon
2014-09-07 15:16 ` Ezequiel Garcia
2014-09-08 8:45 ` Roger Quadros
2014-09-08 10:53 ` Roger Quadros
2014-09-10 12:48 ` Ezequiel Garcia
2014-09-10 13:05 ` Roger Quadros
2014-09-17 8:33 ` Brian Norris
2014-09-17 9:54 ` Ezequiel Garcia
2014-09-18 2:54 ` Brian Norris
2014-09-10 20:15 ` pekon [this message]
2014-09-08 11:28 ` Ezequiel Garcia
2014-09-06 19:56 ` [PATCH 3/3] nand: omap2: Replace pr_err with dev_err Ezequiel Garcia
2014-09-08 8:30 ` [PATCH 0/3] nand: omap2: Two and a half improvements Roger Quadros
2014-09-08 11:31 ` Ezequiel Garcia
2014-09-08 11:47 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5410B153.80303@pek-sem.com \
--to=pekon@pek-sem.com \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=guido@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).