* [PATCH] UBIFS: Align the dump messages of SB_NODE
@ 2014-09-20 6:55 hujianyang
2014-09-26 10:36 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: hujianyang @ 2014-09-20 6:55 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: linux-mtd
I found the dump messages of UBIFS_SB_NODE is not aligned. This
patch remove the extra space from the line which is retracted.
Signed-off-by: hujianyang <hujianyang@huawei.com>
---
fs/ubifs/debug.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 177b015..d0bcf92 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -334,9 +334,9 @@ void ubifs_dump_node(const struct ubifs_info *c, const void *node)
pr_err("\tkey_fmt %d (%s)\n",
(int)sup->key_fmt, get_key_fmt(sup->key_fmt));
pr_err("\tflags %#x\n", sup_flags);
- pr_err("\t big_lpt %u\n",
+ pr_err("\tbig_lpt %u\n",
!!(sup_flags & UBIFS_FLG_BIGLPT));
- pr_err("\t space_fixup %u\n",
+ pr_err("\tspace_fixup %u\n",
!!(sup_flags & UBIFS_FLG_SPACE_FIXUP));
pr_err("\tmin_io_size %u\n", le32_to_cpu(sup->min_io_size));
pr_err("\tleb_size %u\n", le32_to_cpu(sup->leb_size));
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] UBIFS: Align the dump messages of SB_NODE
2014-09-20 6:55 [PATCH] UBIFS: Align the dump messages of SB_NODE hujianyang
@ 2014-09-26 10:36 ` Artem Bityutskiy
2014-09-28 1:58 ` hujianyang
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2014-09-26 10:36 UTC (permalink / raw)
To: hujianyang; +Cc: linux-mtd
On Sat, 2014-09-20 at 14:55 +0800, hujianyang wrote:
> I found the dump messages of UBIFS_SB_NODE is not aligned. This
> patch remove the extra space from the line which is retracted.
>
>
> Signed-off-by: hujianyang <hujianyang@huawei.com>
This was not a typo, this was intentional. We first print the all flags
in a hex format, and then we "decode" it and print the values of the
individual flags with an additional indent. The indent is to make it
clear that these line belong to the flags, and they are not independent
values.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] UBIFS: Align the dump messages of SB_NODE
2014-09-26 10:36 ` Artem Bityutskiy
@ 2014-09-28 1:58 ` hujianyang
0 siblings, 0 replies; 3+ messages in thread
From: hujianyang @ 2014-09-28 1:58 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd
On 2014/9/26 18:36, Artem Bityutskiy wrote:
> On Sat, 2014-09-20 at 14:55 +0800, hujianyang wrote:
>> I found the dump messages of UBIFS_SB_NODE is not aligned. This
>> patch remove the extra space from the line which is retracted.
>>
>>
>> Signed-off-by: hujianyang <hujianyang@huawei.com>
>
> This was not a typo, this was intentional. We first print the all flags
> in a hex format, and then we "decode" it and print the values of the
> individual flags with an additional indent. The indent is to make it
> clear that these line belong to the flags, and they are not independent
> values.
>
Oh, thanks for your explanation~!
Hu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-28 1:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-20 6:55 [PATCH] UBIFS: Align the dump messages of SB_NODE hujianyang
2014-09-26 10:36 ` Artem Bityutskiy
2014-09-28 1:58 ` hujianyang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).