From: Roger Quadros <rogerq@ti.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Brian Norris <computersforpeace@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in
Date: Mon, 22 Sep 2014 11:17:13 +0300 [thread overview]
Message-ID: <541FDB09.1080209@ti.com> (raw)
In-Reply-To: <1411231996-6387-6-git-send-email-ezequiel@vanguardiasur.com.ar>
On 09/20/2014 07:53 PM, Ezequiel Garcia wrote:
> This fixes the following build error when omap2_nand is chosen built-in,
> and omap_elm is chosen as a module:
>
> drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
> drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
> drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
> drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>
> Fix this by making omap_elm a 'bool' driver.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Acked-by: <rogerq@ti.com>
--
cheers,
-roger
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f1cf503..549c0cb 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -96,7 +96,7 @@ config MTD_NAND_OMAP2
>
> config MTD_NAND_OMAP_BCH
> depends on MTD_NAND_OMAP2
> - tristate "Support hardware based BCH error correction"
> + bool "Support hardware based BCH error correction"
> default n
> select BCH
> help
>
next prev parent reply other threads:[~2014-09-22 8:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 16:53 [PATCH v4 0/5] nand: OMAP collected fixes Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 1/5] nand: omap2: Remove horrible ifdefs to fix module probe Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 2/5] nand: omap2: Replace pr_err with dev_err Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 3/5] mtd: nand: Move ELM driver and rename as omap_elm Ezequiel Garcia
2014-09-20 16:53 ` [PATCH v4 4/5] mtd: nand: Rename OMAP NAND driver Ezequiel Garcia
2014-09-22 18:49 ` Brian Norris
2014-09-20 16:53 ` [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in Ezequiel Garcia
2014-09-22 8:17 ` Roger Quadros [this message]
2014-09-22 18:58 ` Brian Norris
2014-09-22 19:15 ` Ezequiel Garcia
2014-09-23 8:51 ` Roger Quadros
2014-09-22 8:22 ` [PATCH v4 0/5] nand: OMAP collected fixes Roger Quadros
2014-09-22 12:51 ` Ezequiel Garcia
2014-09-22 15:13 ` Roger Quadros
2014-09-22 18:42 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541FDB09.1080209@ti.com \
--to=rogerq@ti.com \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).