From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XYYZj-00081L-Fy for linux-mtd@lists.infradead.org; Mon, 29 Sep 2014 10:53:03 +0000 Received: by mail-pa0-f41.google.com with SMTP id eu11so1915062pac.14 for ; Mon, 29 Sep 2014 03:52:41 -0700 (PDT) Message-ID: <54293975.9040402@gmail.com> Date: Mon, 29 Sep 2014 16:20:29 +0530 From: Kiran Padwal MIME-Version: 1.0 To: Tanya Brokhman Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities References: <1411886185-7838-1-git-send-email-tlinder@codeaurora.org> In-Reply-To: <1411886185-7838-1-git-send-email-tlinder@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Artem Bityutskiy , linux-arm-msm@vger.kernel.org, open list , dedeking1@gmail.com, linux-mtd@lists.infradead.org, Richard Weinberger , Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Tanya, On Sunday 28 September 2014 12:06 PM, Tanya Brokhman wrote: > If there is more then one UBI device mounted, there is no way to > distinguish between messages from different UBI devices. > Add device number to all ubi layer message types. > > > Signed-off-by: Tanya Brokhman > > --- > drivers/mtd/ubi/attach.c | 138 ++++++++++++++++++++---------------- > drivers/mtd/ubi/build.c | 130 ++++++++++++++++++++-------------- > drivers/mtd/ubi/cdev.c | 37 +++++----- > drivers/mtd/ubi/debug.c | 9 +-- > drivers/mtd/ubi/eba.c | 54 +++++++------- > drivers/mtd/ubi/fastmap.c | 108 ++++++++++++++++------------ > drivers/mtd/ubi/io.c | 177 +++++++++++++++++++++++++++------------------- > drivers/mtd/ubi/kapi.c | 6 +- > drivers/mtd/ubi/misc.c | 6 +- > drivers/mtd/ubi/ubi.h | 13 ++-- > drivers/mtd/ubi/vmt.c | 76 +++++++++++--------- > drivers/mtd/ubi/vtbl.c | 54 ++++++++------ > drivers/mtd/ubi/wl.c | 87 +++++++++++++++-------- > 13 files changed, 521 insertions(+), 374 deletions(-) Compilation breaks while I try to compile with this patch. May be you need to update remaining ubi layer messages also. Thanks, --Kiran