From: Kiran Padwal <kiran.padwal@smartplayin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
linux-arm-msm@vger.kernel.org,
Tanya Brokhman <tlinder@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>,
dedeking1@gmail.com, linux-mtd@lists.infradead.org,
Kiran Padwal <kiran.padwal21@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Mon, 29 Sep 2014 18:02:37 +0530 [thread overview]
Message-ID: <54295165.4030201@smartplayin.com> (raw)
In-Reply-To: <54294A01.8070505@nod.at>
On Monday 29 September 2014 05:31 PM, Richard Weinberger wrote:
> Am 29.09.2014 12:50, schrieb Kiran Padwal:
>> Hi Tanya,
>>
>> On Sunday 28 September 2014 12:06 PM, Tanya Brokhman wrote:
>>> If there is more then one UBI device mounted, there is no way to
>>> distinguish between messages from different UBI devices.
>>> Add device number to all ubi layer message types.
>>>
>>>
>>> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>>>
>>> ---
>>> drivers/mtd/ubi/attach.c | 138 ++++++++++++++++++++----------------
>>> drivers/mtd/ubi/build.c | 130 ++++++++++++++++++++--------------
>>> drivers/mtd/ubi/cdev.c | 37 +++++-----
>>> drivers/mtd/ubi/debug.c | 9 +--
>>> drivers/mtd/ubi/eba.c | 54 +++++++-------
>>> drivers/mtd/ubi/fastmap.c | 108 ++++++++++++++++------------
>>> drivers/mtd/ubi/io.c | 177 +++++++++++++++++++++++++++-------------------
>>> drivers/mtd/ubi/kapi.c | 6 +-
>>> drivers/mtd/ubi/misc.c | 6 +-
>>> drivers/mtd/ubi/ubi.h | 13 ++--
>>> drivers/mtd/ubi/vmt.c | 76 +++++++++++---------
>>> drivers/mtd/ubi/vtbl.c | 54 ++++++++------
>>> drivers/mtd/ubi/wl.c | 87 +++++++++++++++--------
>>> 13 files changed, 521 insertions(+), 374 deletions(-)
>>
>> Compilation breaks while I try to compile with this patch.
>> May be you need to update remaining ubi layer messages also.
>
> Please always share the errors you face.
> Maybe you have a different config.
Sure, I will take care of this next time.
Macros have been changed but some instances of older macros still remained, which caused many errors like,
drivers/mtd/ubi/build.c: In function ‘ubi_init’:
drivers/mtd/ubi/build.c:1322:49: error: expected ‘)’ before ‘err’
ubi_err("block: cannot initialize, error %d", err);
^
>
> Thanks,
> //richard
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-09-29 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 6:36 [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities Tanya Brokhman
2014-09-28 8:01 ` Richard Weinberger
2014-09-28 8:24 ` Tanya Brokhman
2014-09-28 12:15 ` Artem Bityutskiy
2014-09-28 12:14 ` Artem Bityutskiy
2014-09-28 12:01 ` Artem Bityutskiy
2014-09-30 8:02 ` Tanya Brokhman
2014-09-29 10:50 ` Kiran Padwal
2014-09-29 12:01 ` Richard Weinberger
2014-09-29 12:32 ` Kiran Padwal [this message]
2014-09-29 12:37 ` Richard Weinberger
2014-09-30 7:30 ` Tanya Brokhman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54295165.4030201@smartplayin.com \
--to=kiran.padwal@smartplayin.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dedeking1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kiran.padwal21@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).