From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.codeaurora.org ([198.145.11.231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XYrtB-0006QY-Rf for linux-mtd@lists.infradead.org; Tue, 30 Sep 2014 07:30:26 +0000 Message-ID: <542A5BF8.3030103@codeaurora.org> Date: Tue, 30 Sep 2014 10:30:00 +0300 From: Tanya Brokhman MIME-Version: 1.0 To: Richard Weinberger , Kiran Padwal Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities References: <1411886185-7838-1-git-send-email-tlinder@codeaurora.org> <54293975.9040402@gmail.com> <54294A01.8070505@nod.at> <54295165.4030201@smartplayin.com> <54295274.4020805@nod.at> In-Reply-To: <54295274.4020805@nod.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: Artem Bityutskiy , linux-arm-msm@vger.kernel.org, open list , linux-mtd@lists.infradead.org, Kiran Padwal , Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 9/29/2014 3:37 PM, Richard Weinberger wrote: > Am 29.09.2014 14:32, schrieb Kiran Padwal: >> On Monday 29 September 2014 05:31 PM, Richard Weinberger wrote: >>> Am 29.09.2014 12:50, schrieb Kiran Padwal: >>>> Hi Tanya, >>>> >>>> On Sunday 28 September 2014 12:06 PM, Tanya Brokhman wrote: >>>>> If there is more then one UBI device mounted, there is no way to >>>>> distinguish between messages from different UBI devices. >>>>> Add device number to all ubi layer message types. >>>>> >>>>> >>>>> Signed-off-by: Tanya Brokhman >>>>> >>>>> --- >>>>> drivers/mtd/ubi/attach.c | 138 ++++++++++++++++++++---------------- >>>>> drivers/mtd/ubi/build.c | 130 ++++++++++++++++++++-------------- >>>>> drivers/mtd/ubi/cdev.c | 37 +++++----- >>>>> drivers/mtd/ubi/debug.c | 9 +-- >>>>> drivers/mtd/ubi/eba.c | 54 +++++++------- >>>>> drivers/mtd/ubi/fastmap.c | 108 ++++++++++++++++------------ >>>>> drivers/mtd/ubi/io.c | 177 +++++++++++++++++++++++++++------------------- >>>>> drivers/mtd/ubi/kapi.c | 6 +- >>>>> drivers/mtd/ubi/misc.c | 6 +- >>>>> drivers/mtd/ubi/ubi.h | 13 ++-- >>>>> drivers/mtd/ubi/vmt.c | 76 +++++++++++--------- >>>>> drivers/mtd/ubi/vtbl.c | 54 ++++++++------ >>>>> drivers/mtd/ubi/wl.c | 87 +++++++++++++++-------- >>>>> 13 files changed, 521 insertions(+), 374 deletions(-) >>>> >>>> Compilation breaks while I try to compile with this patch. >>>> May be you need to update remaining ubi layer messages also. >>> >>> Please always share the errors you face. >>> Maybe you have a different config. >> >> Sure, I will take care of this next time. >> >> Macros have been changed but some instances of older macros still remained, which caused many errors like, >> >> drivers/mtd/ubi/build.c: In function ‘ubi_init’: >> drivers/mtd/ubi/build.c:1322:49: error: expected ‘)’ before ‘err’ >> ubi_err("block: cannot initialize, error %d", err); > > Ohh. :( > Tanya, did you test your patch? > Of course I did. I used nandsimulator on a virtual machine to test all patches. Perhaps my error was testing them all together (with read-disturb) and this got lost somehow. It's very strange you got compilation errors. I'm sorry for the inconvenience. Will look into this today and upload a new version ASAP. (with all previous comments addressed as well) > Thanks, > //richard > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation